Call to a member function getDisplayname() on null in WorkspaceListBuilder.php

Updated patch from #2 for 9.4 support.

The title sounds more like a bug then a support request.

There is no issue summary so that should be added.
This will need steps to reproduce
Test cases

Trying to fix the CM Failed.

Added tests please review

User interface changes

do we need any meaningful text here instead of "/"?
or empty?

The last submitted patch, 15: 3167126-15-test-only.patch, failed testing. View results →

Think it should have some default if no user exists.

Not sure if it's possible to know previous user. Or if some other text should work but just "/" is confusing.

Added text "User not found" instead of "/" and also updated the tests.

Think this is a good change.

The last submitted patch, 18: 3167126-18.patch, failed testing. View results →

Seems random.

The common way to display information that is not known is the string N/A (stands for not available), let's use that here as well.

+++ b/core/modules/workspaces/src/WorkspaceListBuilder.php
@@ -121,7 +129,7 @@ public function buildRow(EntityInterface $entity) {
+      'owner' => $displayName,

The whole patch could be shortened to: 'owner' => ($owner = $entity->getOwner()) ? $owner->getDisplayName() : $this->t('N/A'),

amateescu → changed the visibility of the branch 3167126-10.1.x to hidden.

Applied the suggestions from #22 and opened a fresh MR.

Cleaned up patches as fix is in MR.

Test-only was already ran

1) Drupal\Tests\workspaces\Functional\WorkspaceTest::testWorkspaceList
Behat\Mink\Exception\ResponseTextException: The text "Summer event" was not found anywhere in the text of the current page.
/builds/issue/drupal-3167126/vendor/behat/mink/src/WebAssert.php:907
/builds/issue/drupal-3167126/vendor/behat/mink/src/WebAssert.php:293
/builds/issue/drupal-3167126/core/tests/Drupal/Tests/WebAssert.php:956
/builds/issue/drupal-3167126/core/modules/workspaces/tests/src/Functional/WorkspaceTest.php:309
/builds/issue/drupal-3167126/vendor/phpunit/phpunit/src/Framework/TestResult.php:728
ERRORS!
Tests: 9, Assertions: 162, Errors: 1.

Main parts of issue summary is there.

Fix came from sub-maintainer so can assume fix is approved.

LGTM!

Backported to 10.2.x as an eligible bug fix. The "N/A" string is already used in core so no translation issues.

Committed and pushed 0aaa9b8d49 to 11.x and a69343b5b5 to 10.3.x and 099a9c2139 to 10.2.x. Thanks!

longwave → closed merge request !6973

Automatically closed - issue fixed for 2 weeks with no activity.