- Issue created by @iancawthorne
- 🇧🇪Belgium cedricl
Also noticed this issue after updating form 2.1.3 to 2.1.4. I downgraded for now, but might be a good thing to look at changes made from 2.1.3 to 2.1.4.
- 🇬🇧United Kingdom iancawthorne
Yes, I can confirm that is the case for me too. Works on create pages on 2.1.3, but not on 2.1.4.
- Assigned to atul_ghate
- Merge request !74Issue #3462436:Preview only works when editing content, not creating. → (Merged) created by Unnamed author
- Status changed to Needs review
5 months ago 12:31pm 25 July 2024 - 🇮🇳India atul_ghate
The issue was due to the wrong order of parameters being passed to the samePagePreviewRenderPreview JavaScript function. In version 2.1.3, the code used: $response->addCommand(new InvokeCommand(NULL, 'samePagePreviewRenderPreview', [$entity->uuid()]));
However, in version 2.1.4, an additional NULL parameter was added: $response->addCommand(new InvokeCommand(NULL, 'samePagePreviewRenderPreview', [NULL, $entity->uuid()]));
This caused the JavaScript function to receive NULL for the UUID, resulting in it not working correctly. By correcting the order of the parameters, the issue was resolved. i have aslo confirmed that view mode is working as well. - 🇬🇧United Kingdom iancawthorne
I can confirm the patch resolves the issue for me.
- Issue was unassigned.
- Status changed to RTBC
5 months ago 2:32pm 26 July 2024 - 🇮🇳India dishakatariya
Hi, I have verified this issue with the #6 patch applied successfully on D11 version.
Testing Steps:
1. Goto your local D11 version.
2. Install the module.
3. Go to the admoin/content
4. Add content and check Preview only works when editing content, not creating.Test Results:
Now the preview works during creating the node as well.Attached the Before and After Screenshots as well.
Hence moving to RTBC
RTBC+1 - First commit to issue fork.
-
cosmicdreams →
committed 8bf0985b on 2.1.x authored by
atul_ghate →
Issue #3462436: Preview only works when editing content, not creating
-
cosmicdreams →
committed 8bf0985b on 2.1.x authored by
atul_ghate →
- Status changed to Fixed
5 months ago 8:08pm 10 August 2024 - 🇮🇳India atul_ghate
Hi @cosmicdreams ,
Thanks for merging the MR.
I noticed that I wasn't credited for resolving this issue. Could you let me know if there's something I might have missed?
- 🇺🇸United States cosmicdreams Minneapolis/St. Paul
I don't think you did anything wrong. Much of what governs this system is automated. From what I can see you have been credited
Automatically closed - issue fixed for 2 weeks with no activity.
- 🇲🇾Malaysia jonloh
Looks like it's not working again on Drupal 10.3.6 with new content, as shown in the screencast here.
Only works well when I edit content.
- 🇲🇾Malaysia jonloh
Reverting the code from patch #6 seems to resolve the issue for Drupal 10.3.6.
It looks like we may need to create a separate version specifically for Drupal 10 to ensure compatibility.
- 🇫🇮Finland YevKo Espoo
This change is not being pulled when the last version of the module is installed.