Espoo
Account created on 26 February 2018, over 6 years ago
  • Technical Competence Manager at Exoveย 
#

Merge Requests

Recent comments

๐Ÿ‡ซ๐Ÿ‡ฎFinland YevKo Espoo

This is not fixed. Confirm missing buttons for Drupal 10.3.7 and Gin 3.0.0-rc13. Unchecking the "Sticky buttons" solves the issue. Example of missing buttons: editing settings of the view, adding a field to the search index etc

๐Ÿ‡ซ๐Ÿ‡ฎFinland YevKo Espoo

The patch does not apply anymore. Plus, as I mentioned in https://www.drupal.org/project/environment_indicator/issues/3065135#comm... โ†’ the problem reported here is fixed by the solution in that issue.

๐Ÿ‡ซ๐Ÿ‡ฎFinland YevKo Espoo

Yes, this happens. Perhaps, a field label should be changed?

๐Ÿ‡ซ๐Ÿ‡ฎFinland YevKo Espoo

For me MR 56 works well, with the domain-based language negotiation. No extra slashes.

I also think that https://www.drupal.org/project/environment_indicator/issues/3092900 โ†’ is a duplicate of this issue, since the problem reported there is fixed by this patch

๐Ÿ‡ซ๐Ÿ‡ฎFinland YevKo Espoo

I was able to reproduce the issue with 11.0.1 and MR fixed it!

๐Ÿ‡ซ๐Ÿ‡ฎFinland YevKo Espoo

I wasn't able to reproduce the issue.

  1. Install Drupal 11.0.1 with the standard profile
  2. Install Focal point with composer require drupal/focal_point (gets 2.1.1). Enable it.
  3. Enable Media library
  4. Change widget to Image (Focal point) foe the Media library form, leave default settings
  5. Configure a new image style to use Focal Point Scale and Crop
  6. Use this image style on the Article's image field.
  7. Create article, add image and save with default focal point
  8. Edit article, move focal point, save.
  9. It gets re-cropped.

Save result with adding a new Media reference field and changing a focal point in the media library after attaching the media t the article.

๐Ÿ‡ซ๐Ÿ‡ฎFinland YevKo Espoo

I wasn't able to reproduce the issue following this steps:

Steps to reproduce

  1. Install Drupal 11.0.1 with the standard profile
  2. Enable Content Translation
  3. Install Paragraphs with composer require drupal/paragraphs and enable it
  4. Add a language, e.g. Finnish in my case
  5. Create a paragraph type, e.g. Text
  6. Create a Pain text field on the paragraph
  7. Enable translation of the paragraph and it's fields.
  8. Add a Paragraphs field to the Basic page content type and allow our Text paragraph there
  9. Create a Basic page in English, save it and click Edit again
  10. Start creating a Finnish translation in the other tab
  11. Save the translation. It is getting saved.
  12. Save an English translation. Saves as well.
  13. Both translations work well

No Core or paragraph patches used.

๐Ÿ‡ซ๐Ÿ‡ฎFinland YevKo Espoo

Tested with the fresh install of 11.0-dev on Olivero.
1. Created a Content block with the content in the body
2. Placed the block to the Footer top and Footer bottom, no visibiity modifications made
3. Browsed the site when logged in as an anonymous - block shows in both cases.


๐Ÿ‡ซ๐Ÿ‡ฎFinland YevKo Espoo

i confirm that #11 solves the issue. Drupal 10.3.5

๐Ÿ‡ซ๐Ÿ‡ฎFinland YevKo Espoo

I'll report more findings if we are able to track down the issue further. Of course any debug or test instructions that we can run and report here would help.

Heikki, I can see that both sites of yours have their default language as something else than English. Have you already tried changing it to English? My colleagues said that this change fixed the translation issue. Meaning:

1. default_langcode: en in system.site.yml
2. selected_langcode: site_default in language.negotiation.yml
3. Make sure that every configuration is in English

I need to make this work on one of the sites as well and will report how this workaround went.

๐Ÿ‡ซ๐Ÿ‡ฎFinland YevKo Espoo

For those who are facing the same problem with failing to use the plain diff https://git.drupalcode.org/project/google_tag/-/merge_requests/58.diff ( happens for me on 2.0.6 version): the issue is with the lack of quotes around the path of the newly added file. When generated with git diff --staged --patch > xxx.patch from the command line the patch applies. And attached here.

3203811-34.patch โ†’

๐Ÿ‡ซ๐Ÿ‡ฎFinland YevKo Espoo

Tested and works well!

๐Ÿ‡ซ๐Ÿ‡ฎFinland YevKo Espoo

MR doesn't work and produces the same error TypeError: mb_strlen(): mentioned in #5

๐Ÿ‡ซ๐Ÿ‡ฎFinland YevKo Espoo

Reviewed the PR, made a small comment.

In UI everything works as expected.

In Claro though, a link without href has an accent color. Shall we handle the same change for Claro?

๐Ÿ‡ซ๐Ÿ‡ฎFinland YevKo Espoo

Tested, works well.

๐Ÿ‡ซ๐Ÿ‡ฎFinland YevKo Espoo

Looks good!

๐Ÿ‡ซ๐Ÿ‡ฎFinland YevKo Espoo

Hi,

https://git.drupalcode.org/project/drupal/-/merge_requests/7792

I have done a re-roll of the existing fork to 11.x first and then applied changes mentioned in this issue:

  • Slogan has been moved inside the 'site-branding__text' container, placed below the site name with the small gutter between. This setup works well with any type of logo, or without the logo.
  • Color of the slogan is the same as of the site name (white). The issue with the text color against grey or white backgrounds is reported separately https://www.drupal.org/project/drupal/issues/3443881 ๐Ÿ› Text color in the header does not adapt to the header background color Active

Screenshots in different setups:




๐Ÿ‡ซ๐Ÿ‡ฎFinland YevKo Espoo

This is better to be worked on after https://www.drupal.org/project/drupal/issues/3188136 ๐Ÿ› The site slogan doesn't show with Olivero Needs work is merged to avoid merge conflicts

๐Ÿ‡ซ๐Ÿ‡ฎFinland YevKo Espoo

YevKo โ†’ changed the visibility of the branch 11.x to hidden.

๐Ÿ‡ซ๐Ÿ‡ฎFinland YevKo Espoo

YevKo โ†’ made their first commit to this issueโ€™s fork.

๐Ÿ‡ซ๐Ÿ‡ฎFinland YevKo Espoo

Update: This patch fixes the issue of excluding a language prefix from the paginated pages.

๐Ÿ‡ซ๐Ÿ‡ฎFinland YevKo Espoo

Hello @gbyte,

I can confirm the issue listed here.

When a language prefix is set to the default language of the site,

links of the paginated sitemap get a prefix included as well:, when they shouldn't

The last screenshot is from the https://xxx.com/sitemap.xml page. When paginated links are assessed they go to 404 pages.

๐Ÿ‡ซ๐Ÿ‡ฎFinland YevKo Espoo

I confirm this happening with Drupal 10.1

๐Ÿ‡ซ๐Ÿ‡ฎFinland YevKo Espoo

I confirm that the solution works in D10

๐Ÿ‡ซ๐Ÿ‡ฎFinland YevKo Espoo

YevKo โ†’ created an issue.

๐Ÿ‡ซ๐Ÿ‡ฎFinland YevKo Espoo

YevKo โ†’ made their first commit to this issueโ€™s fork.

๐Ÿ‡ซ๐Ÿ‡ฎFinland YevKo Espoo

YevKo โ†’ made their first commit to this issueโ€™s fork.

๐Ÿ‡ซ๐Ÿ‡ฎFinland YevKo Espoo

I am getting the same errors. I found out that it is not the disabling of the Advanced aggregation, but disabling of Aggregate CSS files and
Aggregate JavaScript files what leads to the site getting up again.

๐Ÿ‡ซ๐Ÿ‡ฎFinland YevKo Espoo

YevKo โ†’ created an issue.

Production build 0.71.5 2024