- Issue created by @froboy
- Merge request !140fix: [#3446881] Handle php warning when translation is enabled. β (Open) created by froboy
- last update
8 months ago 237 pass - Status changed to Needs review
8 months ago 3:46pm 13 May 2024 - Status changed to RTBC
8 months ago 7:15am 14 May 2024 - First commit to issue fork.
- last update
8 months ago 237 pass - π¬π§United Kingdom jonathan1055
JSchref, did you mean to erase the issue summary?
I need to check the steps to reproduce, and it would be good to have test coverage for this, as clearly there are some incorrect assumptions in the code.
- Status changed to Needs work
7 months ago 8:58am 16 June 2024 - π¬π§United Kingdom jonathan1055
I have reverted JSchref erasing of the issue summary.
I followed the 'steps to reproduce' but could not get the error. Specifically what I did was
- Enable Scheduler
- Enable "Content Translation" core module
- Add a new language via /admin/config/regional/language (Config -> Region and Language -> Language )
- Enable a content type for translation content (via Content type -> edit -> language settings -> tick both chekcboxes "Show language selector on create and edit pages" and "enable translation"
- Save is OK, no error
- Or if you enable you enable translation on admin/config/regional/content-language (Config -> Region and Language -> Content language and translation) - there is still no problem and no error on save
I am not saying that there is no problem, it is just that there must be something else in your set-up which is causing this error. I need to understand what is causing the problem and replicate it, before committing any fix.
- π¬π§United Kingdom jonathan1055
On π Undefined array key "translatable" in _scheduler_translation_validate() (line 732 of modules/contrib/scheduler/scheduler.module) Active I was able to replicate the error, the key difference is that Language needs to be installed but not Content Translation. I am going to see if I can add some simple test coverage for this.
- π¬π§United Kingdom jonathan1055
I have added a simple test to make sure the Content Language form can be saved even when the Translation module is not enabled.
https://git.drupalcode.org/project/scheduler/-/pipelines/393018
The "test only changes" job shows that we do now have coverage for this, because the new test fails when the fix is reverted.