Fata error with Drupal 11

Hi,

We have fixed the construct error. However, after fixing it, we encountered another issue:

Error: Type of Drupal\same_page_preview\Form\SettingsForm::$typedConfigManager must be Drupal\Core\Config\TypedConfigManagerInterface (as in class Drupal\Core\Form\ConfigFormBase) in C:\wamp64\www\drupal-alpha\modules\contrib\same_page_preview\src\Form\SettingsForm.php on line 15

To resolve this error, we needed to use "typedConfigManager" since we are using the "ConfigFormBase". We have fixed the issue. Please review the patch.

Thank you!

Thanks for your report. Reviewing your patch.

Patch didn't work, constructor promotion was in the parent class, so adding the variable was double-declaring it. Also fixed whitespace issues. Converted to MR to make it easier as well.

1. Before applying the MR /admin/config/content/same-page-preview has a fatal error as described in the issue summary.
2. After applying the MR /admin/config/content/same-page-preview is now working without fatal error.

Agreed this is 'Major' as the module is not usable in Drupal 11 without it unless we consider manually setting the config as a valid workaround, but that takes a particular skillset.

Thanks!

Hiya Scott. This issue has a high priority for me. I'll be getting some time to fix it next week it seems.

@scott_euser would it be alright to bounce this edit back to you. The fix is the same in principal. But I felt it was important to get the order of injected objects to be the same as what I'm seeing in core.

Thanks! Retested and works well still in D11

Automatically closed - issue fixed for 2 weeks with no activity.

This change is not being pulled when the last version of the module is installed.