Collapsed nav-tabs status not exposed to screen reader

Can we add an assertion somewhere that checks this attribute to make sure it doesn't break again?

We looked at this today at the end of Drupal a11y office hours and based on that I moved the aria attribute to the correct button element. This still doesn't have a test.

Thanks for raising this at today's Drupal A11y Office Hour Simo!

@smustgrave About tests: I don't a lot of test with themes currently. And this is theme specific f.e. Olivero does this already, but uses a different script. How would we go about testing this?

Tested, works well.

So we get so few nightwatch tests wasn't sure if the test-only feature worked with nightwatch, it doesn't. And since I'm pretty sure I don't have nightwatch working locally opened a test-only branch with just the test to see it fail.

Unfortunately it didn't

What I meant in #5 was if there was an existing test that we can just put a check that the attribute exists.

We agreed to add the duplicate nightwatch test as it is adding a comment with @lauriii during DrupalCamp Finland+Baltics contrib day - since locally it passed and we didn't find examples of nightwatch tests testing multiple themes/modules.

Ah I gotcha, then nvm!

Oh. Now I see that that test actually runs again an Olivero install.
So I'll need to make it run with actual Claro. My bad, need to fix it.

Now I have a Nightwatch test that uses Claro theme for the test site and fails against 11.x without and succeeds against this MR. So even if it's using much of the test code from Olivero it now actually tests the menu in Claro.

Attaching both the test results run locally.

smustgrave → closed merge request !7808

Also pushed the change to the test-only branch and got https://git.drupalcode.org/issue/drupal-3432632/-/pipelines/159222

Closed the MR so the bot doesn't pick up on it.

Great job on the tests!

nod_ → credited andypost → .

nod_ → credited kostyashupenko → .

Committed bd81352 and pushed to 11.x. Thanks!

nod_ → closed merge request !7126