Text color in the header does not adapt to the header background color

Created on 27 April 2024, 9 months ago
Updated 14 May 2024, 8 months ago

Problem/Motivation

While working on https://www.drupal.org/project/drupal/issues/3188136 🐛 The site slogan doesn't show with Olivero Needs work and testing, it has been noticed that changing "Header site branding background color" in the Olivero settings to grey or white makes the text unreadable, since it's color is fixed to white in the CSS.

Steps to reproduce

On admin/appearance/settings/olivero change Header site branding background color to gray or white. Reload page/

Proposed resolution

Either make a color change conditionally in the header-site-branding.css or introduce a color system.

User interface changes

Black text on both grey and white backgrounds in the header.

🐛 Bug report
Status

Postponed: needs info

Version

11.0 🔥

Component
Olivero 

Last updated 4 days ago

Created by

🇫🇮Finland YevKo Espoo

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

  • Issue created by @YevKo
  • 🇫🇮Finland YevKo Espoo

    This is better to be worked on after https://www.drupal.org/project/drupal/issues/3188136 🐛 The site slogan doesn't show with Olivero Needs work is merged to avoid merge conflicts

  • First commit to issue fork.
  • 🇮🇳India ahsannazir

    The issue is not reproducible at my end. I see the css already present to handle this scenario.

    .site-branding--bg-gray .site-branding__text,
    .site-branding--bg-white .site-branding__text {
      color: var(--color--primary-50);
    }

  • Status changed to Needs review 8 months ago
  • 🇮🇳India ahsannazir

    Moving this to NR to confirm if it is working as expected

  • 🇮🇳India arunkumark Coimbatore

    @ahsannazir @YevKo
    In the Oliver theme settings, we can able to adjust the Text color based on the chosen Site Branding Color. The settings are available under the Olivero Color Scheme Settings.

    There are already predefined colors drop-down and custom text color options also available. Hope this option will help to adjust the Color scheme from the UI.

  • 🇮🇳India Kanchan Bhogade

    The issue is not reproducible on my end also; It is Working as expected

  • Status changed to Postponed: needs info 8 months ago
  • 🇺🇸United States smustgrave

    @YevKo as the reporter can you provide additional steps.

Production build 0.71.5 2024