Fix handling of unknown file extensions in FileMediaFormatterBase

Hello @mfb ,
i did not face same error like you can say. could please verify my step. if i am wrong please guide me to reproduced error.
1. setup project using 3466462-deprecated-function-explode this branch.
2. create file field in basic page and set file extension foobaz, mp3.
3. create node and upload mp3 file.
4. open node in front page. (i can't see error).
5. Again i try another way like create view for basic page and render file field and open that page still i can't see error.

Can you please provide proper steps to reproduced error

Thanks!!

@Chandansha Oops I forgot to mention configuring the field formatter in the steps to reproduce, that is probably what you were missing

I have fixed deprecated function error.
Please review.
Thanks!!

Research needs to be done to figure out why it's null. Putting just a simple check could be masking a larger issue.

@smustgrave the premise is configuring an unknown file extension, so I think it's reasonable for the mime type to be null.

And silently ignoring/masking the null seems fine to me, unless folks think it's important enough to log a warning that an extension with unknown mime type was configured.

Left at needs work since I suggested changes on the merge request.

Hi @smustgrave

The issue occurs because when an unknown file type is created, it doesn't find the MIME type, resulting in a null return from this function.

https://git.drupalcode.org/project/drupal/-/blob/11.0.0/core/lib/Drupal/Core/File/MimeType/ExtensionMimeTypeGuesser.php#L929

One solution would be to set 'application/octet-stream' as the MIME type for unknown file types. This would prevent the error from occurring. However, I'm not sure if this would be the best approach or if the current implementation in the MR is sufficient, as it already resolves the problem.

Possibly will need to have test coverage to handle when unknown file type is sent.

Looks like MimeTypeGuesser::guessMimeType() returns 'application/octet-stream' if all of the registered guesser(s) have returned null. But ExtensionMimeTypeGuesser::guessMimeType(), being a specific guesser, returns null.

In this case, the specific guesser is being called directly, which is a bit odd, but doing it this way means a null mime type is possible.

So yes, just handling this possible null seems like the easiest solution.

Hi @Chandansha,
I added the check that @mfb requested in the function where the error occurs. I hope you don't mind.

This issue was most likely caused by fixing this other one... rolling back the change introduced by that issue probably would not be a good fix, since it addressed and important mismatch between expected behavior vs. actual implementation.

Added this scenario to the existing functional test

Ran test-only feature https://git.drupalcode.org/issue/drupal-3466462/-/jobs/2398791 and shows the coverage and code change seems straight forward.

Will go ahead and mark.

I have only noticed the title here.

The title should be a description of what is being fixed or improved. The title is used as the git commit message so it should be meaningful an concise. See List of issue fields → .

Thanks @mxr576 for taking care of that so quickly!

I had this problem with the documents media type when was in the UI for Manager display it had this error and i was prevented from making changes. I mention this here in case anyone encounters the same.

'Deprecated function: explode(): Passing null to parameter #2 ($string) of type string is deprecated in Drupal\file\Plugin\Field\FieldFormatter\FileMediaFormatterBase::mimeTypeApplies() (line 171 of core/modules/file/src/Plugin/Field/FieldFormatter/FileMediaFormatterBase.php)' was repeated many times. (on D 10.3.2)

It seems by default the documents type has a long list of acceptable suffixes:
file_extensions: 'txt rtf doc docx ppt pptx xls xlsx pdf odf odg odp ods odt fodt fods fodp fodg key numbers pages'

replacing with the shorter list: txt, doc, docx, pdf -- solves the problem. maybe this should be looked at.

@blb I created a followup issue @ 🐛 Some file extensions in field.field.media.document.field_media_document.yml are missing from ExtensionMimeTypeGuesser Active

Hi,

Thanks for the work here!

Encountered the same issue and MR fixes the bug on Core 10.3.2

Hiding out of date patch

Just encountered the same error message when adding a new view mode to the Document media type; paired the allowed list in the field to "txt, rtf, doc, docx, ppt, pptx, xls, xlsx, pdf" and it bypasses for now.

We shouldn't be calling ExtensionMimeTypeGuesser (service id 'file.mime_type.guesser.extension') directly, but instead using 'file.mime_type.guesser' which is a service collector and returns a default of 'application/octet-stream' if none are found.

Created a MR that does #29

@kim.pepper But in this case, we have a "fake" file: 'fakedFile.' . $extension So, we only want to retrieve a MIME type based on the extension, not anything else that file.mime_type.guesser might use. Thus only file.mime_type.guesser.extension is used directly.

kim.pepper → closed merge request !9567

Ah you are right. Back to RTBC for MR!9114

I created a task 📌 Create a method for getting the MIME type for a file extension from a map Active that should make looking up the MIME type for an extension less hacky.

Reroll

We don't need a re-roll @peter_serfozo as we are using the MR !9114