Create a method for getting the MIME type for a file extension from a map

Open on Drupal.org →

Created on 23 September 2024, 4 months ago

Problem/Motivation

MimeTypeGuesser is a service for guessing the mime type of a file. It is a service collector that will chain through any services tagged with 'mime_type_guesser'.

In core we only have ExtensionMimeTypeGuesser which looks at the file extension, but there are others that could be used including \Symfony\Component\Mime\FileBinaryMimeTypeGuesser and \Symfony\Component\Mime\FileinfoMimeTypeGuesser.

However, there are at least two places in core where we only want to look up the mime type based on the file extension:

\responsive_image_get_mime_type()
\Drupal\file\Plugin\Field\FieldFormatter\FileMediaFormatterBase::isApplicable()

In both these cases we create a fake file path with the extension and call \Drupal\Core\File\MimeType\ExtensionMimeTypeGuesser::guessMimeType($fakefile).

We should add a new method ExtensionMimeTypeGuesser::getMimeType() can just return the mapped mime type, and make it clear this is different from the logic of guessing the mime type.

Steps to reproduce

Proposed resolution

Add a new method ExtensionMimeTypeGuesser::getMimeType() can just return the mapped mime type.
Refactor existing code to use this method.

Remaining tasks

User interface changes

Introduced terminology

API changes

Data model changes

Release notes snippet

📌 Task

Status

Active

Version

11.0 🔥

Component

file system

Created by

🇦🇺Australia kim.pepper 🏄‍♂️🇦🇺Sydney, Australia

Live updates comments and jobs are added and updated live.

Sign in to follow issues

Comments & Activities

Issue created by @kim.pepper
@kimpepper opened merge request.
Comment 4 months ago →
🇦🇺Australia kim.pepper 🏄‍♂️🇦🇺Sydney, Australia
Comment 4 months ago →
🇮🇹Italy mondrake 🇮🇹
As is, this MR would break BC if something is overriding the file.mime_type.guesser.extension service class. (The Sophron guesser module does that, https://git.drupalcode.org/project/sophron/-/blob/2.1.x/sophron_guesser/...)

I think we should use a deprecation helper to introduce usage of the new method ::getMimeType() based on its existence in the implementation class.
Comment 4 months ago →
🇮🇹Italy mondrake 🇮🇹
Comment 4 months ago →
🇦🇺Australia kim.pepper 🏄‍♂️🇦🇺Sydney, Australia
Hmm. I didn't realise how this was being used.

I think we should use a deprecation helper to introduce usage of the new method ::getMimeType() based on its existence in the implementation class.

I'm not sure about that approach.

It might be better to add a new interface and service and switch that out with a BC layer.
Comment 4 months ago →
🇮🇹Italy mondrake 🇮🇹
Blast from the past, 🐛 Separate MIME type mapping from ExtensionMimeTypeGuesser Needs work .

That one getting stuck led me develop the Sophron module.
Comment 4 months ago →
🇦🇺Australia kim.pepper 🏄‍♂️🇦🇺Sydney, Australia
Ah ok. Let's close this as a duplicate of 🐛 Separate MIME type mapping from ExtensionMimeTypeGuesser Needs work
Comment 3 months ago →
System Message
kim.pepper → closed merge request !9586

contrib.social Blog FAQ Discussions

Production build 0.71.5 2024