matomo_install() should load role without config overrides

I merged in the issue fork the latests commits made on 8.x-1.x + the fix from #3363521

And this is the patch for use in a composer.json

Attaching patch from MR to use with composer.json

I think this is a duplicate of 🐛 Error on hook_install when invoked from drush site-install Fixed at this point. The user module check is bogus as user is a required module, but it uses the API function that is patched to use loadOverrideFree() in the related core issue.

Hi,

I was about to merge, then checking all the comments. Regarding comment 11, then in this case:
- as user is a required module, no need to check for it
- and for the problem of config override, only core patch needs to be applied and nothing to do on Matomo side.

Could someone confirm please?

- and for the problem of config override, only core patch needs to be applied and nothing to do on Matomo side.

Yes and no, the core issue just ensures that all code uses loadOverrideFree(), right now it just fails with an exception when not done directly. It's a last-resort defense against data corruption. But the module now already uses user_role_grant_permissions() as done in the other issue, which is being adjusted in core.

The user module exists check could be removed, but it's a minor thing at best, could also just close this as a duplicate and don't bother.

Thanks for the quick feedback.

Then I will just remove the check for the user module. And config override problem will be fixed in core.

Automatically closed - issue fixed for 2 weeks with no activity.