- ๐บ๐ธUnited States pcate
+1 RTBC. The patch applies cleanly and adding the required Drupal 10 compatability.
volodymyr.umanets โ made their first commit to this issueโs fork.
- @volodymyrumanets opened merge request.
- ๐บ๐ธUnited States JackG102 Falls Church, VA
I will add support for making a D10 release -- we are doing our upgrade and it appears folks have tested this above in the thread.
- ๐ฌ๐ทGreece TheodorosPloumis Greece
I am waiting for this also. We have a 10.x website using this patch and works fine.
Thanks. - ๐บ๐ธUnited States joegraduate Arizona, USA
Patch #2 is working for us but is complicated to use without a D10 compatible release being available.
@aczietlow, @andrewmacpherson, @Derimagia any chance this could get a committed and a new release tagged? Are you seeking new co-maintainers?
- First commit to issue fork.
- ๐ฉ๐ชGermany c-logemann Frankfurt/M, Germany
@joegraduate Using composer-drupal-lenient makes it easy patch in D10.
- ๐บ๐ธUnited States inversed
That composer plugin solved it for me as well.
-
Adarshsri786 โ
authored a9ec8702 on 8.x-2.x
Issue #3310624 by Adarshsri786: D10 Readiness
-
Adarshsri786 โ
authored a9ec8702 on 8.x-2.x
- Status changed to Fixed
over 1 year ago 12:00pm 28 July 2023 - ๐ณ๐ฑNetherlands batigolix Utrecht
Thanks for providing and reviewing the patch.
I created a release 8.x-2.0 that is D10 compatible.
- ๐บ๐ธUnited States jackfoust
For D10, doesn't
core: 8.x
need removed?The 'core_version_requirement' constraint (^9.5 || ^10) requires the 'core' key not be set in modules/composer/migrate_devel/migrate_devel.info.yml
- Status changed to Needs work
over 1 year ago 2:08pm 28 July 2023 Yes. In order to be compatible with D10, you must remove
core: 8.x
.- Status changed to Fixed
over 1 year ago 4:19pm 28 July 2023 - ๐ณ๐ฑNetherlands batigolix Utrecht
Thanks!
I removed this and created a new release.
How can I see this error?
- ๐บ๐ธUnited States jackfoust
I got the error above when I ran a
drush updb
after I updated via composer. - Status changed to Needs review
over 1 year ago 4:51pm 28 July 2023 - ๐บ๐ธUnited States nmangold United States
The correct key was not removed in the last release.
Added a patch that removes the
core: 8.x
. - ๐บ๐ธUnited States jackfoust
@nmangold patch didn't apply for me, patches on info.yml can be tricky - typically need some extra line returns in there.
- ๐บ๐ธUnited States nmangold United States
@jackfoust. I think the problem here is this feature branch is not updated, and does not contain the latest changes from the 8.x-2.x branch. Specifically, the core version requirement was changed to ^9.5 in https://git.drupalcode.org/project/migrate_devel/-/commit/725b66750e1e69....
Here is another patch that will apply cleanly to THIS branch, before it is updated.
If I had push access to the issue branch, I could have updated the branch myself.
- ๐ณ๐ฑNetherlands batigolix Utrecht
I probably made a mistake with the new release.
As far as I can see the line has now been removed from the info yml file in release 8.x-2.1
I tested this locally with composer.
Can you confirm this?
@nmangold let me know if you like to help maintaining the module.
- ๐บ๐ธUnited States nmangold United States
@batigolix Your last commit fixed the issue. https://git.drupalcode.org/project/migrate_devel/-/commit/4bf1ecc56d1a07...
It looks like you did that at the same time I was creating this patch. I missed your comment.
I think this can be marked as fixed.
- ๐บ๐ธUnited States nmangold United States
I updated this branch from 2.x, and pushed. So, this branch has the change, and everything is clear.
- Status changed to Fixed
over 1 year ago 6:21pm 28 July 2023 Automatically closed - issue fixed for 2 weeks with no activity.