Add validation constraints to system.file

Open on Drupal.org →

Created on 26 March 2024, 9 months ago

Updated 17 July 2024, 5 months ago

Problem/Motivation

System module settings has 2 property paths that are not yet validatable:

vendor/bin/drush config:inspect --filter-keys=system.file --detail --list-constraints
➜  🤖 Analyzing…

 Legend for Data: 
  ✅❓  → Correct primitive type, detailed validation impossible.
  ✅✅  → Correct primitive type, passed all validation constraints.
 ---------------------------------------- --------- ------------- ------ ------------------------------------------ 
  Key                                      Status    Validatable   Data   Validation constraints                    
 ---------------------------------------- --------- ------------- ------ ------------------------------------------ 
  system.file                              Correct   67%           ✅❓   ValidKeys: '<infer>'                      
   system.file:                            Correct   Validatable   ✅✅   ValidKeys: '<infer>'                      
   system.file:_core                       Correct   Validatable   ✅✅   ValidKeys:                                
                                                                            - default_config_hash                   
   system.file:_core.default_config_hash   Correct   Validatable   ✅✅   NotNull: {  }                             
                                                                          Regex: '/^[a-zA-Z0-9\-_]+$/'              
                                                                          Length: 43                                
                                                                          ↣ PrimitiveType: {  }                     
   system.file:allow_insecure_uploads      Correct   Validatable   ✅✅   ↣ PrimitiveType: {  }                     
   system.file:default_scheme              Correct   NOT           ✅❓   ⚠️  @todo Add validation constraints here  
   system.file:temporary_maximum_age       Correct   NOT           ✅❓   ⚠️  @todo Add validation constraints here

Steps to reproduce

Proposed resolution

Add validation constraints to:

system.file:default_scheme
system.file:temporary_maximum_age

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

📌 Task

Status

Needs work

Version

11.0 🔥

Component

Last updated 7 days ago

No maintainer

Created by

🇮🇳India srishtiiee

Live updates comments and jobs are added and updated live.

Configuration schema

validation

Sign in to follow issues

Merge Requests

!7516Add validation constraints to system.file
Open
🇮🇳India srishtiiee
updated 5 months ago
!7187Add validation constraints to system.file
Open
🇮🇳India srishtiiee
updated 9 months ago

Comments & Activities

Issue created by @srishtiiee
Merge request !7187add validation constraints → (Open) created by srishtiiee
Pipeline finished with Failed
9 months ago
Total: 182s
#129396
First commit to issue fork.
Pipeline finished with Failed
9 months ago
Total: 477s
#129456
Pipeline finished with Failed
9 months ago
Total: 508s
#129506
Pipeline finished with Failed
9 months ago
Total: 180s
#130305
Status changed to Closed: duplicate 9 months ago9:10am 28 March 2024
Comment 9 months ago →
🇮🇳India srishtiiee
This will be covered in 📌 Add validation constraints to all system.* simple config (except system.rss) Needs work
Status changed to Needs work 8 months ago10:52am 16 April 2024
Comment 8 months ago →
🇮🇳India srishtiiee
Merge request !7516Resolve #3436096 "Add validation constraints to system.file" → (Open) created by srishtiiee
Comment 8 months ago →
🇮🇳India srishtiiee
srishtiiee → changed the visibility of the branch 3436096-add-validation-constraints to hidden.
Pipeline finished with Failed
8 months ago
Total: 506s
#148036
Pipeline finished with Failed
8 months ago
Total: 513s
#148068
Pipeline finished with Failed
8 months ago
Total: 544s
#150101
Pipeline finished with Failed
8 months ago
Total: 1081s
#150231
Pipeline finished with Failed
8 months ago
Total: 195s
#162152
Comment 8 months ago →
🇮🇳India srishtiiee
Pipeline finished with Failed
8 months ago
Total: 1151s
#162153
Comment 8 months ago →
🇧🇪Belgium wim leers Ghent 🇧🇪🇪🇺
Tests are failing and I think we can fix that by just pushing the latest origin/11.x to this issue fork 🤞
Comment 8 months ago →
🇧🇪Belgium wim leers Ghent 🇧🇪🇪🇺
Review posted on MR — if I'd found nothing in my review, then I'd have done #9 for you — but since I can't RTBC this yet anyway, I'll let you handle #9 too 🤓
Pipeline finished with Failed
8 months ago
Total: 521s
#166069
Pipeline finished with Failed
8 months ago
Total: 1558s
#168648
Pipeline finished with Failed
8 months ago
Total: 631s
#168663
Pipeline finished with Failed
8 months ago
Total: 674s
#169499
Pipeline finished with Failed
8 months ago
Total: 610s
#171500
Comment 6 months ago →
🇮🇳India yash.rode pune
yash.rode → made their first commit to this issue’s fork.
Pipeline finished with Failed
6 months ago
Total: 170s
#210495
Pipeline finished with Failed
6 months ago
Total: 186s
#210500
Pipeline finished with Failed
6 months ago
Total: 538s
#210538
Pipeline finished with Canceled
6 months ago
Total: 320s
#212794
Pipeline finished with Success
6 months ago
Total: 549s
#212800
Status changed to Needs review 6 months ago9:45am 1 July 2024
Comment 6 months ago →
🇮🇳India yash.rode pune
Status changed to RTBC 6 months ago1:47pm 1 July 2024
Comment 6 months ago →
🇺🇸United States smustgrave
On a standard profile install on 11.x
Installed configuration inspector and applied the MR

Shows that the system.file is fully validated.

Checking the MR everything appears to have a return type

Believe this one is good to go.
Status changed to Needs work 6 months ago11:28pm 3 July 2024
Comment 6 months ago →
🇬🇧United Kingdom alexpott 🇪🇺🌍
If path is deprecated we should deprecate it. See https://www.drupal.org/about/core/policies/core-change-policies/drupal-d... →

Added some review comments.
Pipeline finished with Failed
6 months ago
Total: 517s
#215530
Pipeline finished with Canceled
6 months ago
Total: 215s
#215552
Pipeline finished with Success
6 months ago
Total: 506s
#215557
Pipeline finished with Failed
6 months ago
Total: 552s
#216492
Pipeline finished with Failed
6 months ago
Total: 581s
#216574
Pipeline finished with Failed
6 months ago
Total: 570s
#219494
Pipeline finished with Success
6 months ago
Total: 479s
#219500
Status changed to Needs review 6 months ago8:10am 9 July 2024
Comment 6 months ago →
🇮🇳India yash.rode pune
Addressed feedback from #14
Status changed to Needs work 6 months ago3:32pm 9 July 2024
Comment 6 months ago →
🇮🇳India narendraR Jaipur, India
I think as per #14, a deprecation message needs to be added for path in system.schema.yml before removing it completely.
Pipeline finished with Failed
6 months ago
Total: 695s
#219930
Pipeline finished with Failed
6 months ago
Total: 508s
#220074
Pipeline finished with Success
6 months ago
Total: 583s
#220365
Pipeline finished with Failed
6 months ago
Total: 532s
#220427
Pipeline finished with Failed
6 months ago
Total: 490s
#220444
Pipeline finished with Canceled
6 months ago
Total: 414s
#220463
Pipeline finished with Success
6 months ago
Total: 449s
#220466
Status changed to Needs review 6 months ago7:07am 10 July 2024
Comment 6 months ago →
🇮🇳India yash.rode pune
Status changed to RTBC 5 months ago8:51am 15 July 2024
Comment 5 months ago →
🇮🇳India narendraR Jaipur, India
Changes looks good to me.
Status changed to Needs work 5 months ago12:23pm 17 July 2024
Comment 5 months ago →
🇬🇧United Kingdom catch
One question on the MR.

contrib.social Blog FAQ Discussions

Production build 0.71.5 2024