[11.x] Remove UpdatePathTestBase::$configSchemaCheckerExclusions

Created on 25 May 2023, about 1 year ago

Problem/Motivation

πŸ“Œ KernelTestBase::$strictConfigSchema = TRUE and BrowserTestBase::$strictConfigSchema = TRUE do not actually strictly validate Fixed made config schema validation in tests more strict.

This required 3 small fixes to default configuration: '' is not a valid URL, and hence failed validation for the uri type. We had to fix those 3 to avoid triggering config schema validation errors in hundreds of tests.

In doing so, ~20 update path tests started failing. Because they are still using the default settings from a prior release of Drupal.

Therefore, the only solution was to exclude these 3 pieces of configuration from strict config schema checks, by defining

  /**
   * {@inheritdoc}
   */
  protected static $configSchemaCheckerExclusions = [
    // These are excluded from config schema checks during update path tests
    // because the fixtures were created from a Drupal version that contained
    // config schema violations in its default configuration. They were fixed in
    // https://www.drupal.org/project/drupal/issues/3361534.
    // @todo Remove this in Drupal 11.
    'media.settings',
    'system.theme.global',
    'update.settings',
  ];

in UpdatePathTestBase.

Steps to reproduce

N/A

Proposed resolution

Remove the quoted code as soon as all update path tests use Drupal the first version in which πŸ“Œ KernelTestBase::$strictConfigSchema = TRUE and BrowserTestBase::$strictConfigSchema = TRUE do not actually strictly validate Fixed shipped, probably Drupal 10.2.

Remaining tasks

None.

User interface changes

None.

API changes

None.

Data model changes

None.

Release notes snippet

None.

πŸ“Œ Task
Status

Closed: outdated

Version

11.0 πŸ”₯

Component
UpdateΒ  β†’

Last updated 3 days ago

  • Maintained by
  • πŸ‡ΊπŸ‡ΈUnited States @tedbow
  • πŸ‡ΊπŸ‡ΈUnited States @dww
Created by

πŸ‡§πŸ‡ͺBelgium Wim Leers Ghent πŸ‡§πŸ‡ͺπŸ‡ͺπŸ‡Ί

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

Production build 0.69.0 2024