Rename constraint ValidKeys to ValidMappingKeys

Hello,
Can you please provide more details on this issue?

Quote from parent:

Also I think this should be named ValidSequenceKeys - this will align this class with ValidKeys (which probably should be named ValidMappingKeys but that's for another issue).

So the ValidKeys constraint and validator class names (and plugin id) need renaming, also the the places in *.schema.yml where that one is used needs renaming.

I think we can do that without a deprecation since it seems it is not used anywhere but core.

See: https://git.drupalcode.org/search?group_id=2&scope=blobs&search=-path%3A...

Working on it.

Please review and let me know if we require any other changes.

Thanks!

There is quite a few test failures and some weird removals that don't make sense. Added comments to the MR.

Sorry for the typos. Make those corrected. Please review now.

Cool! Another step in the right direction. Please check the pipeline, there are phpcs and phpstan errors which should be fixed first. Then we can see if things are stable :)

Hello @bbrala, Now PHPStan and PHPCS errors are fixed.

Great! Next up, there is an error in the unit test which indicate you might have missed a rename of a method, or forgot to undo a rename.

https://git.drupalcode.org/issue/drupal-3518146/-/pipelines/471075/test_...

Hello @bbrala, Thank you for your guidance. I have fixed the issue that you mentioned over here. Please let me know if we require any other changes.

Please check gitlab for more issues with failing tests.

Seems there is still some references to not existing methods. (getDynamicallyValidMappingKeys?)