[PP-1] olivero.settings config schema is wrong

Surprised that removing that cause all those failures. Is it a dependency thing where those other schemas aren't getting loaded?

Is it a dependency thing where those other schemas aren't getting loaded?

Quite possibly the Shortcut module must be installed in all those failing tests.

I see lots of migration test failures. 90% likely that the migration is wrong (i.e. assumes the Shortcut module is installed, which is not guaranteed).

Ah good find!

What about existing sites? Do we need to clean up if Olivero is installed but Shortcut is not?

You are correct. Did a standard install, uninstalled shortcut, config export and still see that third_party_setting in the yml file.

_core:
  default_config_hash: 1TswGK46jyu77aIM7Z-0JVQs5bxHmo-gtgrvrQGMXxc
favicon:
  use_default: true
features:
  comment_user_picture: true
  comment_user_verification: true
  favicon: true
  node_user_picture: false
logo:
  use_default: false
third_party_settings:
  shortcut:
    module_link: true
mobile_menu_all_widths: 0
site_branding_bg_color: default
base_primary_color: '#1b9ae4'

Most sites don't need an update path, for two reasons:

1. 99% of sites have the Shortcut module installed, which means they'll have type: theme_settings.third_party.shortcut, and hence their config is valid
2. We should keep 100% of the sites that have Shortcut installed working the exact same way in Olivero, which means: not modifying their configuration

That means we need to write an update path for the remaining 1% of sites that use Olivero but have the Shortcut module uninstalled, because in those cases, the third party settings in olivero.settings are meaningless noise.

(Sorry for maybe stating the obvious, but I was thinking it through so might as well write it up.)

olivero_post_update_add_olivero_primary_color() and OliveroPostUpdateTest already exist and provide a decent example :) At the start of the post-update function, we'd need something like:

  $module_handler = \Drupal::moduleHandler();
  if ($module_handler->moduleExists('shortcut')) {
    // No config to update.
    return;
  }

(example of that: help_post_update_help_topics_search())

Postponing this on 📌 [PP-1] Add validation constraints to olivero.settings Postponed , which adds more validation.

This bug is a bit annoying.

Contrib (e.g. Gin) is now copying this bug into their own codebase, just to make Config inspector shut up. And this again breaks theme 3rd party settings for everybody else :(