Contrib.social

[PP-1] Ensure deterministic version hashes

Open on Drupal.org →
Created on 3 June 2025, 3 days ago

Overview

📌 Version component prop definitions for SDC and Code components Active brought versioned ComponentSource-specific settings: as either the component itself evolves (an SDC/code component gains new props, a block plugin gains new settings, the field type used for a particular SDC/code component prop shape changes, etc.), we'll be able to still access instances that were created for a previous version and keep those component instances operational.

Furthermore, this also allows storing less information in the ComponentTreeItem's inputs field property.

#3523841 introduced all the necessary infrastructure on the server side (a lot), optimized the storage of inputs for all GeneratedFieldExplicitInputUxComponentSourceBase-powered component sources, updated the client side (a little) to adjust for the changes, and hence kept it all working.

Part of that is:

If we take those scenarios as inputs, we should be able to create a determinstic hashing approach that gives us a unique version ID for each component and set of those constraints.

But that issue did notenable the validation that verifies the versions are indeed deterministic hashes. The logic for that already exists, but if we enable it, 110 tests fail.

So, clearly, the logic in \Drupal\experience_builder\Entity\VersionedConfigEntityBase::generateVersionStringForData() which uses

    $typed_data = \Drupal::service(TypedConfigManagerInterface::class)->createFromNameAndData($config_schema_type, $data);
    assert($typed_data instanceof Mapping);
    $normalized_data = $typed_data->toArray();

… does not quite result in the expected normalization that should result in deterministic hashes 😭

Proposed resolution

Investigate why the result of TypedConfigManagerInterface::createFromNameAndData()->toArray() is not deterministic.

User interface changes

None.

📌 Task
Status

Active

Version

0.0

Component

Config management

Created by

🇧🇪Belgium wim leers Ghent 🇧🇪🇪🇺

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

contrib.social Blog FAQ Discussions
Production build 0.71.5 2024