#data integrity

Approvals across the board, with one exception: technically I still need a +1 from @tedbow or @effulgentsia:

… but that's for one single tiny addition to test coverage: https://git.drupalcode.org/project/experience_builder/-/merge_requests/3... — I'm confident that is not contentious.

So moving ahead and merging.

RTBC+1

Reviewed and approved. It seems MR still needs approval from @tedbow or @effulgentsia.

Slightly clarifying title.

Left even more "Dear reviewer, here's helpful info"-style guiding comments on the MR, prefixed with 💁.

MR is now actually green and definitely ready for review.

While I still want @f.mazeikis' +1, I'm assigning to @longwave because he worked on the cacheability aspects of ApiComponentsController in 📌 Add support for block derivatives Active , which this is keeping, but #3484671 is largely removing 😬 That's why I'd like this to land first, because it proves much more is possible, before we temporarily remove much of it in #3484671…

#8.1 is now also no longer a mystery: https://git.drupalcode.org/project/experience_builder/-/merge_requests/3...

#9's hypothesis is confirmed, although it seems somewhat accidental? 😅 See #2578855-165: Form tokens are now rendered lazily, allow forms to opt in to be cacheable → , where I ask @catch about this.

Documented in https://git.drupalcode.org/project/experience_builder/-/merge_requests/3...

⚠️ I cannot reproduce #8.2 locally: it passes locally with 60!

But … I've been testing using commit 48b0aea1d573d9e01752f9909ec8cd3a1b7e3378 of the 11.x branch, which dates back to October 2.

I already know what causes max-age: 0, and it's XB that ups this to 60 seconds: it's \Drupal\user\Plugin\Block\UserLoginBlock when rendered by FormBuilder for an authenticated user. Just pushed https://git.drupalcode.org/project/experience_builder/-/merge_requests/3... to make that very explicit in the test coverage.

something changed since then. I bet this is thanks to 📌 Form tokens are now rendered lazily, allow forms to opt in to be cacheable Needs review — see the change record → .

@f.mazeikis FYI I’m working on !395 as we speak — I assigned it to me 50 mins ago.

Fortunately I made the exact same changes locally, but with an extra comment explaining it 😊

I’m currently investigating why:

1. config:search.settings appears only in D11, not in D10
2. X-Drupal-Cache-Max-Age is -1 on D11, but 60 on D10

f.mazeikis → made their first commit to this issue’s fork.

Damn that last bit 😬

Needs review from @longwave and @f.mazeikis.

Is IMHO RTBC-worthy and mergeable.

If need be, I could split off the bit to a separate issue + MR, but it's a single commit: https://git.drupalcode.org/project/experience_builder/-/merge_requests/3... — although that uses PHP Fibers 😄

Down to 96.

From 108 failures down to 100.

Expect this to move towards green quickly now 🤓