Fix bugs in update path surfaced by config validation

Drupal\Tests\views\Functional\Update\ViewsFixRevisionIdUpdateTest::testViewsPostUpdateFixRevisionId There should be no errors in configuration 'block.block.claro_help_search'. Errors: Schema key 0 failed with: [] 'uuid' is a required key. Failed asserting that Array &0 ( 0 => '[] 'uuid' is a required key.' ) is true.

protected static $configSchemaCheckerExclusions = [ // The following config trigger config schema validation errors, even after // the update. An update path is needed to fix these. // @see drupal-9.4.0.filled.standard.php.gz // @todo Remove in <follow-up issue to be created> 'block.block.claro_help_search', 'block.block.stark_testblock', 'block.block.testblock', 'editor.editor.test_text_format', 'search.page.help_search', ];

Comments & Activities

Issue created by @wim leers
Comment about 1 year ago →
🇧🇪Belgium wim leers Ghent 🇧🇪🇪🇺
Comment 7 months ago →
🇫🇷France andypost
Does it mean it needs to update dump or we can just add extra fixtures to existing dumps?

Comment 7 months ago →

🇭🇺Hungary mxr576 Hungary

I have just found this issue after updated a project and realized that help_post_update_help_topics_search() created two configs without UUIDd that also made our strict QA pipeline fail, since the exported config in config/sync differs from the active config of clean site created via drush si -y --existing-config.

$ git diff
diff --git a/config/sync/block.block.claro_help_search.yml b/config/sync/block.block.claro_help_search.yml
index aca7524..6695d6d 100644
--- a/config/sync/block.block.claro_help_search.yml
+++ b/config/sync/block.block.claro_help_search.yml
@@ -1,3 +1,4 @@
+uuid: 17c15c63-085d-4ac2-aad3-a19746c37ccd
 langcode: en
 status: true
 dependencies:
diff --git a/config/sync/search.page.help_search.yml b/config/sync/search.page.help_search.yml
index 38d4344..b9b39a9 100644
--- a/config/sync/search.page.help_search.yml
+++ b/config/sync/search.page.help_search.yml
@@ -1,3 +1,4 @@
+uuid: 6f35532e-b3ab-4004-bfb2-db2b4482f004
 langcode: en
 status: true
 dependencies:

This also means that a UUID gets added to these config after a clean site install and can be exported to config/sync, but it would be beneficial if a follow up update hook would be added to fix the could-be-missing UUID problem on existing projects.

Comment 7 months ago →
🇫🇷France andypost
@mxr576 do you mean to add uuid generation to https://git.drupalcode.org/project/drupal/-/blob/10.2.x/core/modules/hel...
Comment 7 months ago →
🇭🇺Hungary mxr576 Hungary
UUID generation was missing from there, indeed.
Now that the update hook is out, it can be fixed, but already updated sites will need a workaround for fixing the missing UUID.

In our case the CI prevented merging the change without a UUID, but others probably weren't that lucky.
Comment 7 months ago →
🇭🇺Hungary mxr576 Hungary
Btw, should not config storage generate a UUID automatically when a new config is saved via standard API calls? Is there an issue for that already?
Comment 7 months ago →
🇭🇺Hungary mxr576 Hungary
Maybe this would have been a scope of #2161149: Force-create new UUIDs in default config objects during initial import/creation → ?

Fix bugs in update path surfaced by config validation

Problem/Motivation

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

Comments & Activities