- Issue created by @wim leers
- Assigned to tedbow
- Merge request !67Resolve #3455728 "ComponentTreeStructure to use a Real tree instead of list" â (Merged) created by tedbow
- Issue was unassigned.
- Status changed to Needs review
6 months ago 6:40pm 25 June 2024 - Status changed to Needs work
6 months ago 1:22pm 5 July 2024 - ð§ðŠBelgium wim leers Ghent ð§ðŠðŠðš
There is a pretty obvious inconsistency in the test data, which is why the scope needs to be expanded to also add test coverage: https://git.drupalcode.org/project/experience_builder/-/merge_requests/6....
- ð§ðŠBelgium wim leers Ghent ð§ðŠðŠðš
Add missing comma to proposed resolution.
- Assigned to bhuvaneshwar
- Assigned to tedbow
- ð§ðŠBelgium wim leers Ghent ð§ðŠðŠðš
- ðĨģ It works! ð
-
// @todo This is a temporary checks until we have a constraint. Just to make // tests fail if we don't have good test values. if (!isset($this->tree[ComponentTreeStructure::ROOT_UUID])) { throw new \UnexpectedValueException('Temp exception replace with constraint. Root UUID is missing.'); }
On a meeting just now I said I was fine with this, but âĶ I now see that the constraint was part of this issue's scope, as mentioned in the issue summary.
Having actually reviewed the MR, I am now convinced by that even more, because since âĻ Allow specifying default props values when opting an SDC in for XB Fixed landed, we now have strict config schema checking for all tests.
Having explicit test coverage for this will also allow us to validate the default value in
config/optional/field.field.node.article.field_xb_demo.yml
â similar to what ð Lift most logic out of ComponentTreeItem::preSave() and into a new validation constraint Needs work is doing.
- ð§ðŠBelgium wim leers Ghent ð§ðŠðŠðš
I wrote #9 before I saw ð Create validation constraint for ComponentTreeStructure Needs work .
Why don't we merge#3460856 with ð Lift most logic out of ComponentTreeItem::preSave() and into a new validation constraint Needs work â i.e. why don't we expand the scope of that? It's exactly the same problem space!
- Assigned to wim leers
- Status changed to Needs review
5 months ago 7:00pm 11 July 2024 - ðšðļUnited States tedbow Ithaca, NY, USA
The pipeline https://git.drupalcode.org/project/experience_builder/-/pipelines/222097 says it is "blocked" but I am not sure what is blocked on
I ran all the jobs and it passed
- ð§ðŠBelgium wim leers Ghent ð§ðŠðŠðš
I have no idea how the
pages
CI job is getting triggered for you ð ðĪŠ Never had that happen!This is obviously actually passing all tests.
I just fixed a few nits, and I see the same status as the summary for the overall CI pipeline. That's just GitLab CI being silly/dumb: it's because the
pages
CI job is the last CI job (in the last stage), and hence that becomes the status/summary.I think we can get rid of it by removing the
manual
rule â then it just won't show up for MRs â and that's indeed working: https://git.drupalcode.org/project/experience_builder/-/merge_requests/6... ð - Issue was unassigned.
- Status changed to RTBC
5 months ago 11:49am 12 July 2024 -
Wim Leers â
committed a1410b6f on 0.x authored by
tedbow â
Issue #3455728 by tedbow, Wim Leers: FieldType: Support storing...
-
Wim Leers â
committed a1410b6f on 0.x authored by
tedbow â
- Status changed to Fixed
5 months ago 11:51am 12 July 2024 Automatically closed - issue fixed for 2 weeks with no activity.