Add validation constraints to file.settings config

Created on 5 March 2024, about 1 year ago

Problem/Motivation

Child of 🌱 [meta] Add constraints to all simple configuration Active - let's add validation constraints the config schema of file.settings so that it can be fully validatable.

Proposed resolution

Add constraints and fix any tests that fail.

✨ Feature request
Status

Active

Version

11.0 πŸ”₯

Component
File moduleΒ  β†’

Last updated 3 days ago

Created by

πŸ‡ΊπŸ‡ΈUnited States phenaproxima Massachusetts

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

  • Issue created by @phenaproxima
  • Pipeline finished with Failed
    about 1 year ago
    Total: 493s
    #112099
  • Pipeline finished with Success
    about 1 year ago
    Total: 555s
    #112124
  • Status changed to Needs review about 1 year ago
  • πŸ‡ΊπŸ‡ΈUnited States phenaproxima Massachusetts
  • Status changed to Needs work about 1 year ago
  • πŸ‡§πŸ‡ͺBelgium wim leers Ghent πŸ‡§πŸ‡ͺπŸ‡ͺπŸ‡Ί

    πŸ“

  • Pipeline finished with Success
    about 1 year ago
    Total: 1141s
    #144864
  • First commit to issue fork.
  • πŸ‡³πŸ‡±Netherlands bbrala Netherlands

    rebased and left question regarding possible solition for file vs directory

  • Pipeline finished with Success
    14 days ago
    Total: 5804s
    #465511
  • πŸ‡³πŸ‡±Netherlands bbrala Netherlands

    All is green, gonna set to needs review for visibility on the one part that still needs decision based on review.

  • πŸ‡§πŸ‡ͺBelgium borisson_ Mechelen, πŸ‡§πŸ‡ͺ

    So the question on the MR is if we can split out a config schema for a file vs a directory. I think that is always different. I don't know of any places in core (or contrib) where you have to enter a path to a directory-or-file. So splitting these into two different schemas makes sense to me.

  • πŸ‡³πŸ‡±Netherlands bbrala Netherlands

    Not 100% positive on what this means;

    Add new types?

    type: directory
    type: file_uri

    And/or constraints to verify existence?

    File?
    Directory?

  • πŸ‡§πŸ‡ͺBelgium borisson_ Mechelen, πŸ‡§πŸ‡ͺ

    Add new types?

    type: directory
    type: file_uri

    Yes, those 2 new types should be made, and those types should get a constraint.
    For file_uri it could be a file_exists check (or that symfony constraint I guess). For directory it should either exist or be in a writable place?

  • πŸ‡ΊπŸ‡ΈUnited States smustgrave

    Should this be moved back to NW?

  • πŸ‡³πŸ‡±Netherlands bbrala Netherlands
  • Pipeline finished with Failed
    about 2 hours ago
    #476500
Production build 0.71.5 2024