Add constraint for Current Theme Condition theme so it can be FullyValidatable

jeeva r → made their first commit to this issue’s fork.

please review this https://git.drupalcode.org/project/drupal/-/merge_requests/12277

Fix looks good, so good that it broke the tests that assumed a theme that it's not installed. We need to fix those tests.

Seems like valid conditions.

Installed the condition_test module and used configuration_inspector

FullyValidatable: ~ constraint is missing

@smustgrave, if the testing was completed and reviewed, please update this issue status.. thank you.

If we add this validation then we also need to add the dependency :)

We need to add something like:

  /**
   * {@inheritdoc}
   */
  public function calculateDependencies() {
    if (!$this->configuration['theme']) {
      return [];
    }
    return ['theme' => [$this->configuration['theme']]];
  }

to \Drupal\system\Plugin\Condition\CurrentThemeCondition

And we need an update function to at least save all blocks where the condition plugin is used...

And we need an update function to at least save all blocks where the condition plugin is used...

Still appears needed.