- Issue created by @wim leers
- Status changed to Needs review
over 1 year ago 3:17pm 23 November 2023 - π§πͺBelgium wim leers Ghent π§πͺπͺπΊ
I think we should add explicit test coverage for all methods on
TypedConfigManager
, because it's unclear which code paths work correctly and which ones fail in the way described in the issue summary and demonstrated in the basic test coverage already in the MR. - Status changed to Needs work
over 1 year ago 7:53pm 24 November 2023 - πΊπΈUnited States smustgrave
The test added seemed to work. Not sure if this issue is meant to include all test coverage or if that should be a follow up. Could that be noted in IS?
- π§πͺBelgium borisson_ Mechelen, π§πͺ
I think the plan is to include all test coverage in this issue, I think that would make the most sense?
- π§πͺBelgium wim leers Ghent π§πͺπͺπΊ
Bumping to given the data corruption/pollution nature of the problem.
- heddn Nicaragua
I think this is what is breaking π Fix head tests or fix related functionality if necessary Active . Something between 10.2 and 10.3 changed dramatically enough that this happens all the time with that module.
- heddn Nicaragua
Something is overriding the typedDataManager. Adding a
$definition->setTypedDataManager($this->container->get('config.typed'));
seems to fix this for the contrib project. I'm not sure we actually want to do more than just do that on the contrib project so I'm going to remove that as a blocker. I've updated the test coverage. But we still want to make sure all the methods are tested i.e. #6.