- Issue created by @Berdir
- Assigned to Sourav_Paul
- ๐ฎ๐ณIndia nishtha.pradhan
nishtha.pradhan โ made their first commit to this issueโs fork.
- Merge request !8734Avoid TypeError if config entity dependencies are NULL. โ (Closed) created by nishtha.pradhan
- Issue was unassigned.
- Status changed to Needs review
about 2 months ago 1:19pm 10 July 2024 - ๐ฎ๐ณIndia Sourav_Paul Kolkata
@nishtha.pradhan
This is unethical, when you see that an issue is assigned to someone, you shouldn't assign it to yourself, until the user has unassigned it by him/her-self.....
Please follow Drupal standard....
- Status changed to RTBC
about 2 months ago 9:03pm 15 July 2024 - ๐บ๐ธUnited States smustgrave
@nishtha.pradhan that is correct if an issue is assigned to a user they should be given a chance to work or address it. If the issue had been ideal for a week or two with no update then you could of unassigned. Just an FYI for next time.
Actual code change seems straight forward.
- Status changed to Needs review
about 2 months ago 2:07am 17 July 2024 - ๐ฌ๐งUnited Kingdom catch
This either needs test coverage or at least confirmation from @berdir that it fixes the regression found.
Also need a follow-up to add an assertion or something so that developers are informed of the problem.
- Status changed to RTBC
about 2 months ago 6:34am 18 July 2024 - ๐จ๐ญSwitzerland Berdir Switzerland
This looks good to me. I verified by manually changing dependencies in a vocabulary config to NULL through config API, then resaving in the UI.
I'm not sure about test coverage or even an assert, because the thing is that nothing needs to be done if we just let the save proceed, it will automatically fix itself and be saved as an array. The only exception I could see is if this is in default config of a module, but not sure if we can or need to detect this. In the case where we saw this, it was a very old site with very old configuration for some vocabularies, that haven't been resaved in ages, and the taxonomy vocabulary update now resaved all them.
- Status changed to Fixed
about 2 months ago 6:38am 19 July 2024 - ๐ฌ๐งUnited Kingdom catch
OK that makes sense. Going to go ahead and commit this so that it's possible to update to the next 10.3 patch release for sites hitting this. Committed/pushed to 11.x and cherry-picked back through to 10.3.x, thanks!
- ๐ฎ๐ณIndia nishtha.pradhan
Hi @Sourav_Paul, my apologies, I am new to contributing, so was not aware of the standards.
Will keep this in mind, thanks. Automatically closed - issue fixed for 2 weeks with no activity.