Component config entity should validate that the SDC actually (still) exists

Open on Drupal.org →

Created on 26 July 2024, 4 months ago

Updated 3 September 2024, 2 months ago

Overview

This is the "used SDC" equivalent of the "used field type" scenario that was addressed in 📌 [PP-1] Prevent modules from being uninstalled if they provide field types used in an Experience Builder field Postponed .

Proposed resolution

experience_builder.component.*:component must be (after replacing + with : — see \Drupal\experience_builder\Entity\Component::convertIdToMachineName()) one of \Drupal\Core\Plugin\DefaultPluginManager::getDefinitions()
Explicit test coverage in \Drupal\Tests\experience_builder\Kernel\Entity\ComponentValidationTest.

User interface changes

None.

📌 Task

Status

Closed: outdated

Component

Config management

Created by

🇧🇪Belgium wim leers Ghent 🇧🇪🇪🇺

Live updates comments and jobs are added and updated live.

Configuration schema

validation

Needs tests
The change is currently missing an automated test that fails when run with the original code, and succeeds when the bug has been fixed.

DX (Developer Experience)
Enhances developer experience.

blocker

Sign in to follow issues

Comments & Activities

Issue created by @wim leers
Comment 4 months ago →
🇧🇪Belgium wim leers Ghent 🇧🇪🇪🇺
Actually, the Component config entity already handles this, largely. So we don't need all that infrastructure.

But we're missing some validation here.
Assigned to f.mazeikis
Comment 3 months ago →
🇧🇪Belgium wim leers Ghent 🇧🇪🇪🇺
@f.mazeikis ran into this problem while working on 📌 Auto-create/update Component config entities for all discovered SDCs that meet XB's minimum criteria Fixed , and this validation would have caught it. So, prioritizing this.
Comment 3 months ago →
🇧🇪Belgium wim leers Ghent 🇧🇪🇪🇺
Comment 3 months ago →
🇧🇪Belgium wim leers Ghent 🇧🇪🇪🇺
This blocks #3470550 — see #3470550-16: Component config entities are incomplete: missing entries for optional props, causing errors in ComponentPropsForm → .
Issue was unassigned.
Status changed to Closed: outdated 2 months ago5:01pm 3 September 2024
Comment 2 months ago →
🇧🇪Belgium wim leers Ghent 🇧🇪🇪🇺
https://git.drupalcode.org/project/experience_builder/-/merge_requests/2... solved this as part of 📌 Component config entity should validate that the SDC actually (still) exists Active .

contrib.social Blog FAQ Discussions

Production build 0.71.5 2024