@anybody I recreated this patch for the 4.x branch
I don't have time for tests unfortunately but if you want them it should be trivial to add them (and if I find some time soon ill add them myself).
Hope this helps.
I reworked this patch so it uses the same logic from the APIKeyAuth, (so no code duplication on detection)
it also returns NULL when no other response is appropriate for check. (so it explicitly returns nothing instead of implicitly)
sysosmaster → created an issue.
now also deployed on the 2.0.2
that mail should than be on the Module page, not this documentation place... and a call to action towards the module page is fine.
the link you added here implies that you are the Drupal.org endorsed place to get support, which you aren't.
so, change it to a button to the section on the module page listing the maintainers and how to contact them, and it would be fine (imho).
Further more, you are talking to the guy who made said implementation in RocketChat, its not tied to that module at all, it was modeled after the drupal.org/project/oauth2_server → if you just follow the same well known paths it will work (as you should, if your implementation is compliant with the OIDC specs. I am happy there is another way of using Rocketchat with Drupal. just use the standards that are there unless you have a good reason not too. (and as far as I can see... you have none, but I could be mistaken... ofc.)
If you want to discuss this, either contact me through the contact link on my user page. or find me on Drupalchat.me @Sysosmaster
Removed Support "call to actions"... which should not be on Drupal.org in this manner.
@nikhal16, No adding mailto links to funnel support towards you!
also, your edit didn't address the issues I originally flagged.