- Issue created by @alexpott
- πΊπΈUnited States phenaproxima Massachusetts
I absolutely think it is the correct behavior. We cannot, and should not, expect recipe authors to dig all the way through the extensions' dependency trees to list everything explicitly - besides, the dependencies may change without warning. This would also be a major DX improvement for recipe authoring. They should only list what they want -- the fact that those extensions have dependencies is a detail that should not be relevant to recipe authors.
So +1000 for this.
- π¬π§United Kingdom alexpott πͺπΊπ
Note we do this at the moment... see
foreach ($modules as $module) { if ($module_data[$module]->requires) { $modules = array_merge($modules, array_keys($module_data[$module]->requires)); } }
in \Drupal\Core\Recipe\InstallConfigurator::__construct()
I think this issue should remove the @todo and add test coverage
- Merge request !109Remove redundant dependencies in Standard recipes β (Open) created by phenaproxima
- Status changed to Needs review
5 months ago 3:09pm 16 April 2024 - πΊπΈUnited States phenaproxima Massachusetts
Wrote explicit test coverage for InstallConfigurator, and removed the todo along with all the redundant dependencies listed in the Standard recipe suite.
- Status changed to RTBC
5 months ago 3:45pm 16 April 2024 - π¬π§United Kingdom alexpott πͺπΊπ
Committed and pushed 8af7fa958bf to 11.x and be3780bbcb2 to 10.3.x. Thanks!
-
alexpott β
committed be3780bb on 10.3.x
Issue #3439715 by phenaproxima, alexpott: Test automatically including...
-
alexpott β
committed be3780bb on 10.3.x
-
alexpott β
committed 8af7fa95 on 11.x
Issue #3439715 by phenaproxima, alexpott: Test automatically including...
-
alexpott β
committed 8af7fa95 on 11.x
- Status changed to Fixed
5 months ago 3:46pm 16 April 2024 - 8db4ef1f committed on patch
Update recipe 11.x patch 8af7fa95 Issue #3439715 by phenaproxima,...
- 8db4ef1f committed on patch
- e78be3b5 committed on patch
Update recipe 10.3.x patch be3780bb Issue #3439715 by phenaproxima,...
- e78be3b5 committed on patch
Automatically closed - issue fixed for 2 weeks with no activity.