Recipes with default content cannot be applied twice due to UUID duplication

I followed the validation steps, but was unable to apply the second recipe.

My process:

# Checkout the repo.
❯ git clone git@git.drupal.org:project/distributions_recipes.git
❯ cd distributions_recipes
# Get to the issue code.
❯ git remote add distributions_recipes-3441557 git@git.drupal.org:issue/distributions_recipes-3441557.git
❯ git fetch distributions_recipes-3441557
❯ git checkout -b 'default-content-duplicate' --track distributions_recipes-3441557/'default-content-duplicate'
# Install dependencies.
❯ composer install
# Install Drupal
❯ php core/scripts/drupal install
# Start a web server.
❯ php core/scripts/drupal quick-start
# I then changed 2 recipes to require the basic_shortcuts recipe.
# Apply the first.
❯ php core/scripts/drupal recipe core/recipes/editorial_workflow

 [OK] Editorial workflow applied successfully

# Apply the second.
❯ php core/scripts/drupal recipe core/recipes/image_media_type

In EntityMethodDeriver.php line 59:

  Class "Drupal\shortcut\Entity\ShortcutSet" does not exist


recipe <path>

Try installing Shortcut first?

It worked okay for me.

I did it this way:

drush si minimal -y
# Apply the basic_shortcuts recipe directly
php core/scripts/drupal recipe core/recipes/basic_shortcuts
# Now apply the Standard recipe, which also runs basic_shortcuts
php core/scripts/drupal recipe core/recipes/standard

That worked fine.

Conversely, if I check out 11.x and do the same command sequence, I get the expected SQL error:

  SQLSTATE[23000]: Integrity constraint violation: 19 UNIQUE constraint faile  
  d: shortcut.uuid: INSERT INTO "shortcut" ("shortcut_set", "uuid", "langcode  
  ") VALUES (?, ?, ?); Array                                                   
  (                                                                            
      [0] => default                                                           
      [1] => 478b3170-1dfd-49d8-8eb3-f1b285445ab7                              
      [2] => en                                                                
  )

So, as far as I can tell, this MR fixes the problem.

Following the validation steps in #6 I was successfully able to install basic_shortcuts, then standard which proves the content configs are ignored when they have already been applied.

Marking RTBC.

Committed and pushed fa163524cd4 to 11.x and 28cf67bda8f to 10.3.x. Thanks!

Automatically closed - issue fixed for 2 weeks with no activity.