Remove Content security policy icon

Created on 27 September 2022, almost 2 years ago
Updated 27 May 2024, about 2 months ago

Problem/Motivation

This was originally an issue reporting a problem with the security policy icon, but as we looked into it, it became apparent that the icon itself has become a weird edge case and it's better to remove it entirely.

In earlier versions of Project Browser, there were more icons to represent different filter criteria, all of which have been removed other than the security policy icon. This lone icon has been a pesky responsive-layout-thwarting edge case, and does not provide much benefit to justify the inconvenience it causes. Removing it makes maintaining the UI easier and does little harm (if any ) to the user experience.

Original Report Below
The content security policy icon in the filters is not correct on 100 or higher zoom %.
Looks fine for lower zoom %.
Device: MacBook
Chrome: browser

Steps to reproduce

Proposed resolution

Remove the icon from the Filters panel.

Remaining tasks

  • ✅ File an issue about this project
  • ☐ Manual Testing
  • ☐ Code Review
  • ☐ Accessibility Review
  • ☐ Automated tests needed/written?
🐛 Bug report
Status

Fixed

Version

1.0

Component

Code

Created by

🇮🇳India anmolgoyal74

Live updates comments and jobs are added and updated live.
  • Novice

    It would make a good project for someone who is new to the Drupal contribution process. It's preferred over Newbie.

Sign in to follow issues

Merge Requests

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

  • 🇺🇸United States chrisfromredfin Portland, Maine

    Agree with Ben, let's move the logo out of there and put it with the label, or remove it altogether, but it shouldn't be near the radio.

  • 🇺🇸United States chrisfromredfin Portland, Maine
  • 🇺🇸United States leslieg

    Tagged as DrupalCon Lille 23

    We, the mentoring team, are triaging issues for first time contributors at DrupalCon Lille and I think this is a good issue for the contribution day.
    We are reserving this issue so please don't work on this issue if you are not at DrupalCon Lille. You can continue the work when the event is over.

  • 🇮🇳India Vighneshh

    Can we move forward on this issue or is it still on hold ? Please confirm.

  • 🇺🇸United States bnjmnm Ann Arbor, MI

    Looks like I have a +1 from @chrisfromredfin to just remove the icon, so I feel comfortable updating the requirements to fix the reported issue with the Security Icon by removing the darn icon.

    I update the issue summary to reflect this. Have at it @Vighneshh or whoever else!

  • First commit to issue fork.
  • Open on Drupal.org →
    Core: 10.2.x + Environment: PHP 8.1 & MySQL 5.7
    last update 3 months ago
    Waiting for branch to pass
  • Pipeline finished with Failed
    3 months ago
    Total: 411s
    #134260
  • Status changed to Needs review 3 months ago
  • 🇺🇸United States chrisfromredfin Portland, Maine

    The only concern I have with removing it from the filters is that's the only place that intimated what the icon means on the card. I still would like to have the icon on the card, so I think we need a follow-on issue for this that introduces a Legend somewhere in the UI.

    Can someone create that follow-up?

    Also, not sure why the wrench icon is gone. Maybe that needs a follow-up issue, too... 🤔

  • 🇨🇦Canada dalin Guelph, 🇨🇦, 🌍

    I'm at Portland2024 with @tderego and @ptkoroma and we're going to test this merge request within the next hour.

  • 🇸🇱Sierra Leone ptkoroma

    I looked and the issue and can verify that the content security policy icon has been removed and is no longer showing

  • 🇺🇸United States tderego Starkville, MS

    Reviewed the issue and confirmed that the icon has been removed for all view port widths.

  • 🇺🇸United States tderego Starkville, MS
  • 🇺🇸United States tderego Starkville, MS
  • Status changed to RTBC 2 months ago
  • 🇺🇸United States tderego Starkville, MS

    Tested with @ptkoroma at DrupalCon Portland 2024. Looks good.

  • Status changed to Needs work 2 months ago
  • 🇺🇸United States mradcliffe USA

    Thank you for providing manual testing and screenshots everyone!

    It looks like we have merge conflicts so I am changing the status to Needs work, but if those are resolved and the tests pass, then I think this can be switch back to RTBC after that.

  • Status changed to Needs review 2 months ago
  • 🇺🇸United States mradcliffe USA

    Merge conflicts resolved via merge from 1.0.x.

  • Pipeline finished with Failed
    2 months ago
    Total: 997s
    #168939
  • First commit to issue fork.
  • Status changed to RTBC 2 months ago
  • 🇦🇺Australia sime Canberra

    Re-added the bundle.*.js. Tested and still working.

  • Pipeline finished with Failed
    2 months ago
    Total: 376s
    #168982
  • Status changed to Needs work 2 months ago
  • 🇺🇸United States chrisfromredfin Portland, Maine

    There is a linter error in eslint - ProjectIcon appears to still be imported at the top, but never used. Be sure to also remove that extra line.

  • Pipeline finished with Failed
    2 months ago
    Total: 369s
    #169014
  • Pipeline finished with Failed
    2 months ago
    #169036
  • Status changed to Needs review 2 months ago
  • 🇦🇺Australia sime Canberra
  • First commit to issue fork.
  • Pipeline finished with Success
    2 months ago
    Total: 354s
    #169126
  • Status changed to RTBC 2 months ago
  • 🇺🇸United States mherman-pro

    Rebased. Reviewed and tested.

  • Status changed to Fixed 2 months ago
  • 🇺🇸United States bnjmnm Ann Arbor, MI

    Yay! That one little icon added a surprising amount of complexity and I'm glad to see it move to a nice farm up north.

  • Automatically closed - issue fixed for 2 weeks with no activity.

Production build 0.69.0 2024