- 🇺🇸United States chrisfromredfin Portland, Maine
Agree with Ben, let's move the logo out of there and put it with the label, or remove it altogether, but it shouldn't be near the radio.
- 🇺🇸United States leslieg
Tagged as DrupalCon Lille 23
We, the mentoring team, are triaging issues for first time contributors at DrupalCon Lille and I think this is a good issue for the contribution day.
We are reserving this issue so please don't work on this issue if you are not at DrupalCon Lille. You can continue the work when the event is over. - 🇮🇳India Vighneshh
Can we move forward on this issue or is it still on hold ? Please confirm.
- 🇺🇸United States bnjmnm Ann Arbor, MI
Looks like I have a +1 from @chrisfromredfin to just remove the icon, so I feel comfortable updating the requirements to fix the reported issue with the Security Icon by removing the darn icon.
I update the issue summary to reflect this. Have at it @Vighneshh or whoever else!
- First commit to issue fork.
- Merge request !452Issue-3312056:-Remove Content security policy icon → (Merged) created by Vighneshh
- Open on Drupal.org →Core: 10.2.x + Environment: PHP 8.1 & MySQL 5.7last update
8 months ago Waiting for branch to pass - Status changed to Needs review
8 months ago 1:57pm 1 April 2024 - 🇺🇸United States chrisfromredfin Portland, Maine
The only concern I have with removing it from the filters is that's the only place that intimated what the icon means on the card. I still would like to have the icon on the card, so I think we need a follow-on issue for this that introduces a Legend somewhere in the UI.
Can someone create that follow-up?
Also, not sure why the wrench icon is gone. Maybe that needs a follow-up issue, too... 🤔
- 🇨🇦Canada dalin Guelph, 🇨🇦, 🌍
I'm at Portland2024 with @tderego and @ptkoroma and we're going to test this merge request within the next hour.
- 🇸🇱Sierra Leone ptkoroma
I looked and the issue and can verify that the content security policy icon has been removed and is no longer showing
- 🇺🇸United States tderego Starkville, MS
Reviewed the issue and confirmed that the icon has been removed for all view port widths.
- Status changed to RTBC
6 months ago 8:24pm 8 May 2024 - 🇺🇸United States tderego Starkville, MS
Tested with @ptkoroma at DrupalCon Portland 2024. Looks good.
- Status changed to Needs work
6 months ago 3:48pm 9 May 2024 - 🇺🇸United States mradcliffe USA
Thank you for providing manual testing and screenshots everyone!
It looks like we have merge conflicts so I am changing the status to Needs work, but if those are resolved and the tests pass, then I think this can be switch back to RTBC after that.
- Status changed to Needs review
6 months ago 4:41pm 9 May 2024 - First commit to issue fork.
- Status changed to RTBC
6 months ago 5:51pm 9 May 2024 - 🇦🇺Australia sime Melbourne
Re-added the bundle.*.js. Tested and still working.
- Status changed to Needs work
6 months ago 6:25pm 9 May 2024 - 🇺🇸United States chrisfromredfin Portland, Maine
There is a linter error in eslint - ProjectIcon appears to still be imported at the top, but never used. Be sure to also remove that extra line.
- Status changed to Needs review
6 months ago 7:53pm 9 May 2024 - First commit to issue fork.
- Status changed to RTBC
6 months ago 9:11pm 9 May 2024 -
bnjmnm →
committed 30e24a50 on 1.0.x authored by
Vighneshh →
Issue #3312056 by sime, mradcliffe, mherman-pro, anmolgoyal74, tderego,...
-
bnjmnm →
committed 30e24a50 on 1.0.x authored by
Vighneshh →
- Status changed to Fixed
6 months ago 6:08pm 13 May 2024 - 🇺🇸United States bnjmnm Ann Arbor, MI
Yay! That one little icon added a surprising amount of complexity and I'm glad to see it move to a nice farm up north.
Automatically closed - issue fixed for 2 weeks with no activity.