- Issue created by @mherchel
- 🇺🇸United States mherchel Gainesville, FL, US
Talking with @chrisfromredfin at D4D, this looks like it was caused by a bad re-roll from ✨ Change layout to make plugin-specific content more clear Fixed
We should remove the ID also
- Merge request !396Issue #3376206: Project list <ul> tag has multiple accessibility issues → (Merged) created by mherchel
- last update
over 1 year ago Custom Commands Failed - Status changed to Needs review
over 1 year ago 5:40pm 21 July 2023 - last update
over 1 year ago 80 pass - Status changed to RTBC
about 1 year ago 12:13pm 15 November 2023 - 🇩🇪Germany marcoliver Neuss, NRW, Germany
Looks good.
tabindex
androle
are removed, label is set as described. Marking RTBC. - First commit to issue fork.
- last update
10 months ago 77 pass - last update
10 months ago Custom Commands Failed - last update
10 months ago 62 pass, 1 fail - last update
10 months ago 77 pass - 🇮🇪Ireland lostcarpark
I have rebased to make mergeable again. The first time the tests ran, they failed on a FunctionalJS test, but when I reran they completed successfully. I think it might be a timing issue.
- last update
10 months ago 81 pass, 2 fail - last update
10 months ago 81 pass, 2 fail - last update
10 months ago 71 pass, 1 fail - First commit to issue fork.
- 🇺🇸United States bernardm28 Tennessee
Here is an image of how it looks after the rebase.
The grid does not look the same but that is likely just because this rebase does not include the new compile CSS assets.
- Status changed to Needs review
8 months ago 2:45am 8 April 2024 - Status changed to RTBC
8 months ago 9:18am 10 April 2024 - 🇩🇪Germany marcoliver Neuss, NRW, Germany
Rebased MR looks good to me. Current pipeline failures seem to be unrelated and out of scope for this task, so marking as RTBC.
-
chrisfromredfin →
committed 076d2145 on 1.0.x authored by
mherchel →
Issue #3376206 by bernardm28, lostcarpark, mherchel, marcoliver,...
-
chrisfromredfin →
committed 076d2145 on 1.0.x authored by
mherchel →
- Status changed to Fixed
8 months ago 2:09pm 10 April 2024 - 🇺🇸United States chrisfromredfin Portland, Maine
OK, this is merged - but the ESLint and PHPStan errors confuse me. I am merging to see if 1.0.x runs without those errors now or if this somehow either introduces them, or if something has changed upstream. So, I'm good with this, but after seeing if 1.0.x fails linters, we may need to open a follow-on.
Automatically closed - issue fixed for 2 weeks with no activity.