- First commit to issue fork.
- π«π·France gbois
I make this modification (see screen Capture dβeΜcran 2023-10-20 aΜ 14.49.58.png) but we need another image file svg to the cross and after i think that was good
- last update
about 1 year ago 56 pass, 1 fail - First commit to issue fork.
- Assigned to jonblatho
- Status changed to Needs review
7 months ago 11:33pm 8 May 2024 Per @gbois's comment above, I replaced the chip close icon with that from the Drupal Design system and updated the padding accordingly. Fixed stylelint issues and this should be ready for review.
Per @gbois's comment above, I replaced the chip close icon with that from the Drupal Design system and removed the old one, and I updated padding accordingly. Merging in months' worth of changes led to some craziness but it looks like stylelint is no longer complaining. The merge request title is no longer accurate; I'm new to contributing and can't figure out how to deal with that β very sorry! That aside, I think this should be ready.
- πΊπΈUnited States chrisfromredfin Portland, Maine
chrisfromredfin β changed the visibility of the branch 3293977-adjust-the-chip to hidden.
- πΊπΈUnited States chrisfromredfin Portland, Maine
chrisfromredfin β changed the visibility of the branch adjust-chip-design to hidden.
-
chrisfromredfin β
committed 746e86ca on 1.0.x authored by
gbois β
Issue #3293977 by jonblatho, gbois, pontus.talvikarhu, rkoller, fjgarlin...
-
chrisfromredfin β
committed 746e86ca on 1.0.x authored by
gbois β
- Status changed to Fixed
7 months ago 12:18am 9 May 2024 - πΊπΈUnited States chrisfromredfin Portland, Maine
Much better; matches Drupal design system and I find it more readable and looks more Drupal-y. Reviewed & tested in DrupalPOd.
Thanks Chris! I wanted to add that I kept the chip background color gray because blue is intended for the "active" state of a chip per the Drupal Design system Figma document. However, there is no "inactive" counterpart in this case. Given that, it seems best to stick with the "default" state as pictured.
Automatically closed - issue fixed for 2 weeks with no activity.