πŸ‡ΊπŸ‡ΈUnited States @kwiseman

Account created on 26 September 2022, almost 2 years ago
#

Merge Requests

More

Recent comments

πŸ‡ΊπŸ‡ΈUnited States kwiseman

To follow up on #11 πŸ› Search API Schema reverts back to 4.2 after deploys or randomly Active : We're now experiencing this issue too. The Solr schema version has spontaneously reverted back to 4.2.10 on all of our environments and multidevs except for Live for a site after being set to 4.3.3.

πŸ‡ΊπŸ‡ΈUnited States kwiseman

@rkoller Thanks for your feedback - I definitely agree with all your suggestions. While the HTML for the modal's title and its closing behavior are out of scope for project browser, the "compatible" button being the first focused element might not be. I'm working on this today and will increase the modal's width as well as test with a screen reader (Voice Over).

πŸ‡ΊπŸ‡ΈUnited States kwiseman

I started working on this for 2.0.x. Given that there are some issues with the modal right now and πŸ“Œ Update project detail page layout & elements Needs work , it's still a work in progress. I copied ModulePage.svelte into the new file DetailModal.svelte to make edits so that simultaneously working on this issue and the one above is (hopefully?) easier.

πŸ‡ΊπŸ‡ΈUnited States kwiseman

kwiseman β†’ changed the visibility of the branch 2.0.x to hidden.

πŸ‡ΊπŸ‡ΈUnited States kwiseman

The 3446416-2x-no-click-categories branch makes the categories look like this screenshot from the slack thread:

But now I'm running into the problem that sometimes the module's descriptions are different heights which causes the categories to be misaligned, but doesn't look great:

πŸ‡ΊπŸ‡ΈUnited States kwiseman

kwiseman β†’ changed the visibility of the branch 3446416-module-categories-on to hidden.

πŸ‡ΊπŸ‡ΈUnited States kwiseman

kwiseman β†’ changed the visibility of the branch 3446416-for-2x-module-categories-on to hidden.

πŸ‡ΊπŸ‡ΈUnited States kwiseman

It seems like the consensus in this thread in the Project Browser slack channel is to solve this problem (a module's category chips looking interactive but not being interactive on the Browse page) by removing the category chips altogether (only on the main Browse page). Prior to the Slack thread, the behavior of the category chips was also touched on in the Drupal UX meeting on 5/24/24. That discussion starts around 33:49 in the video.

I created a new branch for 2.0.x to solve this issue by removing the category chips.

πŸ‡ΊπŸ‡ΈUnited States kwiseman

kwiseman β†’ changed the visibility of the branch 2.0.x to hidden.

πŸ‡ΊπŸ‡ΈUnited States kwiseman

kwiseman β†’ changed the visibility of the branch 2.0.x to hidden.

πŸ‡ΊπŸ‡ΈUnited States kwiseman

kwiseman β†’ changed the visibility of the branch 1.0.x to hidden.

πŸ‡ΊπŸ‡ΈUnited States kwiseman

kwiseman β†’ changed the visibility of the branch 3446591-improve-styling-and to active.

πŸ‡ΊπŸ‡ΈUnited States kwiseman

@nick.murza - Thanks for the suggestion and MR! I also recently had the idea to add the ability for this module to add classes to the dialog's container, titlebar, and content based on what menu is in the modal. I realize the modal could also use a title, but I'm not sure that title should be the same as the modal trigger button's text.

πŸ‡ΊπŸ‡ΈUnited States kwiseman

Regarding comment #3, both sites in question are using the dev release. By default, dev releases won't appear on the Available Updates page. See this documentation: https://www.drupal.org/docs/develop/using-composer/manage-dependencies#s... β†’

πŸ‡ΊπŸ‡ΈUnited States kwiseman

We're having this problem too with sites on core 10.3.0-beta1 and 10.2.6, using the same steps as above. Additionally, when I output the available variables in my theme's image.html.twig template, the alt key is null, and the attributes array doesn't contain an alt key.

πŸ‡ΊπŸ‡ΈUnited States kwiseman

Personally, I think it makes sense to narrow the scope of this issue to just the screenreader accessibility and move the design part to its own issue, given that design for the toggle state doesn't exist yet.

I created a merge request on a new branch that's caught up with 1.0.x and has the same changes.

Also, I forgot to mention in #3 that I manually tested with VoiceOver on a Mac in Firefox. Manual testing with other screen readers and/or browsers is probably necessary.

πŸ‡ΊπŸ‡ΈUnited States kwiseman

kwiseman β†’ changed the visibility of the branch 3446591-improve-styling-and to hidden.

πŸ‡ΊπŸ‡ΈUnited States kwiseman

I added Project Browser's issue for the mini-browser ✨ Create a "mini-browser" UI Active to this issue's description.

πŸ‡ΊπŸ‡ΈUnited States kwiseman

Unfortunately, I couldn't replicate the behavior shown in #12, and I mostly use Firefox. I'm not sure this is a bug because the --grid-column-count variable isn't supposed to change because it's being used to limit the number of possible columns, not directly set the number of columns that will be shown. The CSS that does this is between lines 262-280 in pb.css, and those lines were directly inspired by core (see core/modules/views/css/views-responsive-grid.css). This CSS Tricks article has a more detailed explanation.

πŸ‡ΊπŸ‡ΈUnited States kwiseman

I added the suggested aria-pressed attribute to the Link and Grid buttons that functions similarly to the two button grouping on https://tink.uk.

However, I wasn't sure how to go about applying the hover and active state styling on them given that the background color of the selected display button (either Link or Grid) in any state is the same as the design system's button active state background color. (In other words, the background of a selected Link or Grid display button is always #ADAEB3). When hovering over a selected display button, should it get 15% darker than #ADAEB3, and 30% darker if the user clicks it again? I looked around in the design system and other admin pages to try to find an example to copy, but couldn't.

I was thinking a solution to this hover/active state styling problem could be changing the color of the selected display button to blue, and then apply the design system's hover and active state styling as usual. Project Browser's Figma Designs shows an example of this on the "Updated MVP April 2022" page, on the frames that start with "April 2022: New Design Draft", but since they're called drafts, I wasn't sure.

πŸ‡ΊπŸ‡ΈUnited States kwiseman

kwiseman β†’ made their first commit to this issue’s fork.

πŸ‡ΊπŸ‡ΈUnited States kwiseman

To fix this issue, I copied the code for the module categories' behavior from ModulePage.svelte into Categories.svelte. It seems to work the same on both pages, but it makes the code in ModulePage.svelte seem a bit repetitive. I've noticed that the markup for module categories is a bit different on the Browse tab vs a module's details page, but would it be a good idea to try to re-use Categories.svelte in ModulePage.svelte like some of the other components on the page? Given that the module details page is currently being worked on in issue #3322594 πŸ“Œ Update project detail page layout & elements Needs work , I wasn't sure if I should make this point another issue, but I will if it's helpful.

Also, I noticed that in the CSS for the module details page, the entire `

    ` element holding individual module categories has `cursor: pointer;` applied, but on the Browse tab, I chose to change the cursor on hover for individual module categories so that it doesn't seem like non-interactive parts of the card are clickable. Please let me know which is preferable.
πŸ‡ΊπŸ‡ΈUnited States kwiseman

I noticed that limiting the max-width on individual cards at very wide screen sizes could result in the "Sort by" box and other parts of the UI being isolated (and harder to find) on the right side of the page. I added a screen shot to demo what limiting the max-width could look like. Given other UI changes in progress and @chrisfromredfin 's agreement, I only changed the CSS variable controlling the maximum number of columns.

πŸ‡ΊπŸ‡ΈUnited States kwiseman

kwiseman β†’ changed the visibility of the branch 1.0.x to hidden.

πŸ‡ΊπŸ‡ΈUnited States kwiseman

I think line length is important and should be limited, but I also agree that this seems like an issue better suited for individual themes.

πŸ‡ΊπŸ‡ΈUnited States kwiseman

kwiseman β†’ changed the visibility of the branch 3445811-current-page-not to active.

πŸ‡ΊπŸ‡ΈUnited States kwiseman

kwiseman β†’ changed the visibility of the branch 3445811-current-page-not to hidden.

πŸ‡ΊπŸ‡ΈUnited States kwiseman

Added Portland2024 tag

πŸ‡ΊπŸ‡ΈUnited States kwiseman

kwiseman β†’ changed the visibility of the branch 3444658-remove-the-clear to hidden.

πŸ‡ΊπŸ‡ΈUnited States kwiseman

I'm here!

πŸ‡ΊπŸ‡ΈUnited States kwiseman

I tested the Number filter in Drupalpod 10.1.x with the Umami demo after the last 2 commits by adding an exposed filter for number of servings to the Recipes view, and it works as expected. I wasn't sure if it mattered that the default values for min and max were empty strings (on lines 36 and 37 of src/Plugin/better_exposed_filters/filter/Number.php), so I tried setting them both back to NULL, and it still worked as expected.

πŸ‡ΊπŸ‡ΈUnited States kwiseman

I created a regular and high resolution version of the 2025 social card as media images. I've also updated the Midcamp 2024 wrap up article with the correct graphic.

πŸ‡ΊπŸ‡ΈUnited States kwiseman

I was unable to recreate this issue using Drupal core 10.2.5 with PHP 8.2 and Layout Builder Library 8.x-1.0-beta4. My testing site wasn't customized beyond the standard profile very much (I added the Admin Toolbar module and created a new content type to follow along with the suggested steps).

This last step was a bit unclear to me, but I tried all actions I thought it was referring to:

Thinking that selecting None as LL selection means it will use the "Default" layout (that i had previously set up for ALL nodes of this type) i go to edit that layout to make an adjustment. When i save those changes the following exception is created

Specifically, I tried:

  • Changing and saving the full content view mode's layout.
  • Changing and saving the default view mode's layout (which wasn't using Layout Builder).
  • Changing and saving the layout of an individual node with the layout_selection field set to None.
πŸ‡ΊπŸ‡ΈUnited States kwiseman

@mradcliffe wanted me to mention that when I first saw this design, I thought it was a bookmark, but I do think it works well as a banner too.

Also, I sampled the contrast ratios of the text and dropshadow colors on the "ring" in "Mentoring" (on the left) with my mac's digital color meter, and here are my results:
Contrast of white text on green: 3.9:1 (green was #419232)
Contrast of grey dropshadow on green: 1.86:1 (#b3b3b3 vs #419232)

πŸ‡ΊπŸ‡ΈUnited States kwiseman

Updated status to fixed. Thanks @kenyoOwen!

πŸ‡ΊπŸ‡ΈUnited States kwiseman

I filled out the form to volunteer.

πŸ‡ΊπŸ‡ΈUnited States kwiseman

Thank you, this tool looks useful

πŸ‡ΊπŸ‡ΈUnited States kwiseman

I agree with @greatmatter - Line 47 of superfish.js ending in a comma and not a semicolon is causing a problem for the site we've upgraded to 8.x-1.7.

However, our site is not getting the same error as @papijo. In the browser console, we're getting "Uncaught SyntaxError: expected expression, got keyword 'var'" on line 48.

πŸ‡ΊπŸ‡ΈUnited States kwiseman

I noticed the CSS coding standards are in the process of being updated for Drupal 10, and found a helpful Google doc written by core developers referenced in Issue #3324368 β†’ to use while this work is in progress. This comment is meant to be an "FYI" for other learners and Drupal newcomers looking for guidance like me.

πŸ‡ΊπŸ‡ΈUnited States kwiseman

We noticed that Umami has the file: /core/profiles/demo_umami/config/install/core.entity_view_mode.node.card.yml

Does it need to be removed to avoid a conflict?

πŸ‡ΊπŸ‡ΈUnited States kwiseman

Here’s a rough draft description. Thanks @keiserjb for the editing help!

β€œThe configuration split module allows a site to deploy subsets of its configuration to different environments.”

πŸ‡ΊπŸ‡ΈUnited States kwiseman

Here's a first attempt at a description:
"The DraggableViews module allows items in a view to be rearranged with 'drag and drop' behavior."

πŸ‡ΊπŸ‡ΈUnited States kwiseman

I was having the same issue. Uninstalling and then reinstalling Update Manager fixed it. The site is using Drupal 9.5.8 and PHP 8.1.13.

πŸ‡ΊπŸ‡ΈUnited States kwiseman

I can't wait for MidCamp! Thanks everyone :)

πŸ‡ΊπŸ‡ΈUnited States kwiseman

Thanks for sharing accessibility tools. I can’t wait to use these!

Production build 0.69.0 2024