Remove Modals after They're Closed

I will review this issue.

hello @omkar-pd, I have tested the code on in version 2.0.x-dev and now the modals are getting removed from DOM on click of close button. Added a video recording for reference.

Hi
I have reproduced the issue successfully...
I have tested MR 562 on the Drupal 10.3 version,
The MR is applied cleanly....

Test Result:
Modals created by Project Browser do have their HTML removed from the DOM after they're closed.

RTBC+1

chrisfromredfin → changed the visibility of the branch 3458908-remove-modals-after to hidden.

I found that this would not remove the HTML if the dialog was closed using ESC. Using the Drupal.dialog() api, you can specify a handler to invoke when the modal is closed. I moved the code into there and it seems to be working.

Could someone re-test this with the latest, review my code, ensure it's working, and set it back to RTBC?

Tests failed.

Needs manual tests, but automated tests were failing for flakiness only (retests passed).

Tested this locally. Removes Modals dialog on Esc and on close.

hello @chrisfromredfin, I have tested the code in version 2.0.x-dev and now the modals are getting removed from DOM on click of ESC button and Close Icon both. Added a video recording for reference.

Thanks all, a good little cleanup!

Automatically closed - issue fixed for 2 weeks with no activity.