Carousel indicators for Bootstrap 5 don't use correct HTML

Open on Drupal.org →

Created on 20 June 2024, 5 months ago

Updated 5 July 2024, 5 months ago

Problem/Motivation

I'm currently using Views Bootstrap 5.5.0-beta4 with Drupal core 10.3.0-rc1. I noticed the Twig template for the carousel format is using an <ol> to wrap the indicators, and <li>s for each indicator.

The Bootstrap 5 documentation for the carousel component uses a <div> with <button>s inside for the indicators.

Steps to reproduce

Create a view with the Bootstrap Carousel format. Turn on "Show Indicators".
Look at the view with a Bootstrap 5 based theme enabled. There will be numbers below the indicators (one per indicator).

Proposed resolution

Change the elements accordingly and provide an aria-label attribute for each button.

🐛 Bug report

Status

Fixed

Version

5.5

Component

Carousel

Created by

🇺🇸United States kwiseman

Live updates comments and jobs are added and updated live.

Sign in to follow issues

Merge Requests

!27Carousel indicators for Bootstrap 5 don't use correct HTML
Merged
🇺🇸United States kwiseman
updated 5 months ago

Comments & Activities

Issue created by @kwiseman
Merge request !27Issue #3456057 carousel indicators for bootstrap 5 → (Merged) created by kwiseman
Pipeline finished with Success
5 months ago
Total: 140s
#204088
Status changed to Needs review 5 months ago8:22pm 20 June 2024
Comment 5 months ago →
🇺🇸United States kwiseman
Pipeline finished with Skipped
5 months ago
#204245
First commit to issue fork.
Comment 5 months ago →
System Message

shelane → committed 35a8b78c on 5.5.x authored by kwiseman →
Issue #3456057 by kwiseman: Carousel indicators for Bootstrap 5 don't...
Status changed to Fixed 5 months ago12:01am 21 June 2024
Comment 5 months ago →
🇺🇸United States shelane
Thanks
Comment 5 months ago →
System Message
Automatically closed - issue fixed for 2 weeks with no activity.

contrib.social Blog FAQ Discussions

Production build 0.71.5 2024