- Issue created by @notSOSolo
- First commit to issue fork.
- Merge request !404Issue #3348960: @todo Add return type when php 7.4 support ends. → (Merged) created by lostcarpark
- last update
over 1 year ago Custom Commands Failed - 🇮🇪Ireland lostcarpark
I have added the return type of
JsonResponse|RedirectResponseto theunlock()method.PHPUnit tests are passing, but PHPStan is failing. The PHPStan error seems to be unrelated to this change.
- Status changed to Needs review
over 1 year ago 8:38pm 22 September 2023 - 🇺🇸United States leslieg
Tagged as DrupalCon Lille 23 and Novice
We, the mentoring team, are triaging issues for first time contributors at DrupalCon Lille and I think this is a good issue for the contribution day.
We are reserving this issue so please don't work on this issue if you are not at DrupalCon Lille. You can continue the work when the event is over. - last update
about 1 year ago 62 pass, 1 fail - 🇺🇸United States chrisfromredfin Portland, Maine
After a rebase, the PHPStan errors are gone; waiting for tests to pass, then can RTBC cuz the code looks great.
- last update
about 1 year ago 72 pass, 2 fail - last update
11 months ago 72 pass, 2 fail -
chrisfromredfin →
committed dbd96574 on 1.0.x authored by
lostcarpark →
Issue #3348960: @todo Add return type when php 7.4 support ends
-
chrisfromredfin →
committed dbd96574 on 1.0.x authored by
lostcarpark →
- Status changed to Fixed
8 months ago 6:12pm 2 May 2024 - 🇮🇪Ireland lostcarpark
Great to see this one merged... I'd almost forgotten I'd worked on it!
Automatically closed - issue fixed for 2 weeks with no activity.