Unable to add and install a module via the drupal.org (json:api) source type

In InstallerController.php, it seems like Installing is hard-coded to only support drupalorg_mockapi:

    // @todo Expand to support other plugins in https://drupal.org/i/3312354.
    $source = $this->enabledSourceHandler->getCurrentSources()['drupalorg_mockapi'] ?? NULL;
    if ($source === NULL) {
      return new JsonResponse(['message' => "Cannot download $project->id from any available source"], 500);
    }
    if (!$source->isProjectSafe($project)) {
      return new JsonResponse(['message' => "$project->machineName is not safe to add because its security coverage has been revoked"], 500);
    }

However, also of note is that $project->id is displayed in that error message, and looks pretty messed up:

Cannot download drupalorg_jsonapi/drupal-starrating-starrating from any available source

@phenaproxima is going to look at this soon (next day or two)

actually this should block alpha

Yeah -- that line needs to be axed, frankly. Should have been removed when the real endpoint was promoted to a full source!

rkoller → changed the visibility of the branch 3459288-unable-to-add to hidden.

rkoller → changed the visibility of the branch 3459288-unable-to-add to active.

That said, we are doing some kind of testing of it, so let's keep it for now but wrap it in an if check.

As already written over on the conversation on slack, tested on a fresh install of 10.3.1. installed with composer, then composer required package manager and project browser only. then went into the project browser folder and added the MR543 and switched to the feature branch. enabled the ui install and tested with the star rating module. The module got successfully installed now via the json api source type. from a manual testing perspective that looks fully functional now. thank you!

since this was worked on and tested and RTBC'd, I'll ship it!

Automatically closed - issue fixed for 2 weeks with no activity.