-
hooroomoo โ
committed 8eae66a5 on 0.x authored by
bnjmnm โ
Issue #3528393 by bnjmnm, wim leers, larowlan: Required image can't be...
-
hooroomoo โ
committed 8eae66a5 on 0.x authored by
bnjmnm โ
- First commit to issue fork.
- ๐บ๐ธUnited States bnjmnm Ann Arbor, MI
Needs signoff that @hooroomoo can grant + some of the test improvements need another set of eyes as they were added after the RTBC
- ๐ฆ๐บAustralia larowlan ๐ฆ๐บ๐.au GMT+10
wim leers โ credited larowlan โ .
- ๐ง๐ชBelgium wim leers Ghent ๐ง๐ช๐ช๐บ
This reminded me of similar server-side code. Which is why I was pretty sure that code is dead now (it was introduced in ๐ Maintain a per-component set of prop expressions/sources Active ). And it indeed is, because tests are passing.
I contemplated whether this should be fixed on the server or client side. But AFAICT it is objectively better for the client-side to handle the fall back to the default value for required props, because that's necessary for:
- real-time updates of the preview canvas โ ๐ Implement endpoint for realtime preview Active
- โฆ especially for code components โ this will allow them to instantly re-render, without talking to the server!
In testing my theory, I ran into consistent e2e test failures (consistent on CI and locally). But then, for reasons I do not understand, it turns out that if I swap the execution order of 2 test cases without changing a single thing, it passes ๐คฏ
RTBC, but needs to be scrutinized by @bnjmnm for that test order swap ๐
- ๐ง๐ชBelgium wim leers Ghent ๐ง๐ช๐ช๐บ
Will take a look later today. The first fileโs changes look sensible! ๐
- ๐ง๐ชBelgium wim leers Ghent ๐ง๐ช๐ช๐บ
This reminded me of ๐ Image upload breaks after optional image without an image gets published Active .
- @bnjmnm opened merge request.
- ๐ง๐ชBelgium wim leers Ghent ๐ง๐ช๐ช๐บ
Is this a pure client-side bug? Because if it's not, then
\Drupal\Tests\experience_builder\Kernel\ComponentInputsFormTest
(introduced in ๐ SDCs with optional images without examples cannot be placed Active ) is the ideal test to expand โ that is currently squarely focused on optional images. - Issue created by @bnjmnm
- Issue created by @bnjmnm
- Issue created by @bnjmnm
- Issue created by @bnjmnm
- Issue created by @bnjmnm