Use Webpack instead of Rollup

Created on 10 January 2023, almost 2 years ago
Updated 13 October 2023, about 1 year ago

Problem/Motivation

This issue follows discussions with @xjm, @catch, @quietone and @justafish in Slack.

Project Browser is intended for eventual inclusion in Drupal core. Webpack is already used as the JavaScript build tool for CKEditor 5 in core. To reduce maintenance burden, core maintainers would prefer if Webpack would also be used for Project Browser, instead of introducing a new tool (Rollup) that appears to do the same thing.

There is also an issue in that we require a dependency evaluation for new core dependencies, which includes evaluation of security policies. @nod_ previously asked about a security policy but the Rollup team have declined to adopt one (as is their right): https://github.com/rollup/rollup/issues/3980 - following this we previously decided not to use Rollup in core (although for the vendor-update feature, which can be done in vanilla JS).

Steps to reproduce

Proposed resolution

Remaining tasks

  • ✅ File an issue about this project
  • ☐ Manual Testing
  • ☐ Code Review
  • ☐ Accessibility Review
  • ☐ Automated tests needed/written?
📌 Task
Status

Postponed

Version

1.0

Component

Code

Created by

🇬🇧United Kingdom longwave UK

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

  • 🇺🇸United States bnjmnm Ann Arbor, MI

    There's not much point in doing this in the contrib module as we'd be recreating a bunch of tooling that already exists in core. I created a core issue/branch that takes care of this using existing core tooling, 📌 bnjmnm pb build Active .

    The branch itself probably shouldn't be merged, there are frozen-in-time Project Browser and Automatic Update modules in there so I can confirm the tooling works. When it comes time to submit Project Browser for core inclusion, we can port over the tooling setup from that MR. Aside from possibly needing to resolve a few dependency things (i did this a few months ago), it should just work.

    I'm going to set this to postponed so it's still officially "open" and visible, but the actual work will likely continue being done in the core queue.

  • 🇺🇸United States chrisfromredfin Portland, Maine
Production build 0.71.5 2024