SDC Required image can't be removed without error

Is this a pure client-side bug? Because if it's not, then \Drupal\Tests\experience_builder\Kernel\ComponentInputsFormTest (introduced in 🐛 SDCs with optional images without examples cannot be placed Active ) is the ideal test to expand — that is currently squarely focused on optional images.

This reminded me of 🐛 Image upload breaks after optional image without an image gets published Active .

Will take a look later today. The first file’s changes look sensible! 👍

wim leers → credited larowlan → .

This reminded me of similar server-side code. Which is why I was pretty sure that code is dead now (it was introduced in 📌 Maintain a per-component set of prop expressions/sources Active ). And it indeed is, because tests are passing.

I contemplated whether this should be fixed on the server or client side. But AFAICT it is objectively better for the client-side to handle the fall back to the default value for required props, because that's necessary for:

• real-time updates of the preview canvas → 📌 Implement endpoint for realtime preview Active
• … especially for code components — this will allow them to instantly re-render, without talking to the server!

In testing my theory, I ran into consistent e2e test failures (consistent on CI and locally). But then, for reasons I do not understand, it turns out that if I swap the execution order of 2 test cases without changing a single thing, it passes 🤯

RTBC, but needs to be scrutinized by @bnjmnm for that test order swap 😇

Needs signoff that @hooroomoo can grant + some of the test improvements need another set of eyes as they were added after the RTBC