Contrib.social

PHPStan error in core merge request conversion

Open on Drupal.org →
Created on 6 April 2023, about 1 year ago
Updated 2 November 2023, 8 months ago

Problem/Motivation

When running scripts/src/Converter.php to make the MR for ✨ Add Alpha level Experimental Package Manager module Needs review now has 1 phpstan error.

----------------------------------------------------------------------------------------------------

Running PHPStan on changed files.
------ ----------------------------------------------------------------------------------------------------------------------------------------------------------
Line core/modules/package_manager/tests/src/Kernel/PackageManagerKernelTestBase.php
------ ----------------------------------------------------------------------------------------------------------------------------------------------------------
94 Class Drupal\Tests\package_manager\Kernel\PackageManagerKernelTestBase has an uninitialized readonly property $fileSystem. Assign it in the constructor.
------ ----------------------------------------------------------------------------------------------------------------------------------------------------------

[ERROR] Found 1 error

Steps to reproduce

Proposed resolution

fix it

Remaining tasks

User interface changes

API changes

Data model changes

🐛 Bug report
Status

Closed: outdated

Version

3.0

Component

Code

Created by

🇺🇸United States tedbow Ithaca, NY, USA

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

  • Issue created by @tedbow
  • First commit to issue fork.
  • Status changed to Needs review 8 months ago
  • Open in Jenkins → Open on Drupal.org →
    Core: 10.1.x + Environment: PHP 8.1 & MySQL 8
    last update 8 months ago
    771 pass
  • Comment 8 months ago →
    🇮🇳India viren18febS

    Hi @tedbow

    fixed the mentioned issues and added a patch for this , please review
    Thanks

  • Status changed to Closed: outdated 8 months ago
  • Comment 8 months ago →
    🇺🇸United States tedbow Ithaca, NY, USA

    @viren18febS sorry this issue is outdated and the Converter.php file is temporary file that we are not worried about phpstan on

contrib.social Blog FAQ Discussions
Production build 0.69.0 2024