- Issue created by @thejimbirch
- First commit to issue fork.
- Merge request !973427558: Output information from the recipe application process → (Open) created by srishtiiee
- Status changed to Needs review
8 months ago 6:06am 1 April 2024 - 🇮🇳India srishtiiee
Added basic logging to the recipe application workflow. The MR needs an initial review for what more can be done here to enhance the debugging process.
Standard recipe application logging looks like this RN: - 🇺🇸United States thejimbirch Cape Cod, Massachusetts
Wow, this is looking really great!
From a functional review, not a code review, you are displaying info for:
- Applying a recipe's dependent recipes.
- Installing modules
- Installing themes
- Verifying the dependent recipes applied
- Applying config actions in a recipe
Some missing things are we don't see the
config:import
happening, nor when the config folder is imported.While you state when
config:actions
are running, it would also be great to see the individual actions being applied.These last two points are often where most of the issues are when creating recipes and would help give a lot more insight into the process to recipe developers.
Thanks for your work on this! This will be a big help for recipe creators.
- Status changed to Needs work
8 months ago 12:51pm 1 April 2024 - 🇺🇸United States phenaproxima Massachusetts
Well, I think this is an awesome idea, and I love what the screenshot is showing us!
I think that we do need to change the way this is implemented, though - right now the MR tightly couples the recipe system to the Console component, and that's not a coupling we should do. I think what's really best here is for the recipe system to accept a logger, which will give us a great deal more flexibility.
- Status changed to Needs review
8 months ago 5:31pm 2 April 2024 - 🇮🇳India srishtiiee
@phenaproxima, thanks! Changed the implementation to injecting a logger instead. Also, added console logging for each config action and config import. It needs another review.
- Status changed to Needs work
8 months ago 7:00pm 2 April 2024 - Status changed to Needs review
8 months ago 8:24am 3 April 2024 - Status changed to Needs work
8 months ago 1:38pm 4 April 2024 - 🇺🇸United States phenaproxima Massachusetts
This is getting better, for sure. I think we need to make it more robust, and we'll need test coverage.
- 🇬🇧United Kingdom alexpott 🇪🇺🌍
This is blocking making the core patch for recipes and should be part of phase 1 recipes.
- 🇺🇸United States phenaproxima Massachusetts
Technically this is not a blocker. But it is part our core MVP, so tagging that way.
- 🇬🇧United Kingdom alexpott 🇪🇺🌍
Got a slightly different approach based on the install batching from #3439702: Allow CLI install of Drupal using recipes → .
See
- Status changed to Needs review
7 months ago 4:12pm 26 April 2024 - 🇬🇧United Kingdom alexpott 🇪🇺🌍
Merged 11.x in now that the installer MR has landed...
- Status changed to RTBC
7 months ago 12:16pm 29 April 2024 - 🇺🇸United States thejimbirch Cape Cod, Massachusetts
Applying the recipe gives much more information with this merge request applied as it runs through the recipe.
Adding the verbose flag,
-v
, adds a very nice summary at the end.I edited a recipe that the standard recipe requires to make it error. The error notice appears before the recipe runs and has a very helpful error message, which was the original motivation for this issue.
Marking this as RTBC. It will be very helpful to recipe creators and users! Thanks!
- 🇬🇧United Kingdom alexpott 🇪🇺🌍
Committed and pushed 300b8e0fb98 to 11.x and 74325fd86e2 to 10.3.x. Thanks!
-
alexpott →
committed 74325fd8 on 10.3.x
Issue #3427558 by srishtiiee, alexpott, phenaproxima, thejimbirch:...
-
alexpott →
committed 74325fd8 on 10.3.x
- Status changed to Fixed
7 months ago 3:30pm 29 April 2024 -
alexpott →
committed 300b8e0f on 11.x
Issue #3427558 by srishtiiee, alexpott, phenaproxima, thejimbirch:...
-
alexpott →
committed 300b8e0f on 11.x
- 1d3f0d41 committed on patch
Update recipe 10.3.x patch 74325fd8 Issue #3427558 by srishtiiee,...
- 1d3f0d41 committed on patch
- b152b673 committed on patch
Update recipe 11.x patch 300b8e0f Issue #3427558 by srishtiiee, alexpott...
- b152b673 committed on patch
- 🇬🇧United Kingdom alexpott 🇪🇺🌍
Cherry picked to ✨ Add recipes api as experimental API to core Needs review
Automatically closed - issue fixed for 2 weeks with no activity.