ESLint should not lint dependencies

Open on Drupal.org →

Created on 11 December 2024, 10 days ago

Problem/Motivation

There's a linting error in one of our -dev composer dependencies (kanopi/imagemagick-configuration), which is causing our pipeline to fail.

Steps to reproduce

Using the upstream at commit f155fe - a linting error in the downloaded recipes/ folder causes the ESLint pipeline stage to fail.

https://github.com/kanopi/imagemagick-configuration/commit/f155fe12ce50d...

Proposed resolution

Make the eslint job skip the recipes/ folder. Not sure if we can do this with some .eslintrc.json, or passing a new parameter to the job, or if we just `rm -fr recipes` the way we do so it skips the sveltejs currently.

🐛 Bug report

Status

Active

Version

2.0

Component

Code

Created by

🇺🇸United States chrisfromredfin Portland, Maine

Live updates comments and jobs are added and updated live.

core-mvp

Sign in to follow issues

Merge Requests

!641ESLint should not lint dependencies
Merged
🇮🇪Ireland lostcarpark
updated 10 days ago

Comments & Activities

Issue created by @chrisfromredfin
First commit to issue fork.
Merge request !641Delete recipes before running eslint checks. → (Merged) created by lostcarpark
Pipeline finished with Success
10 days ago
Total: 411s
#365832
Comment 10 days ago →
🇮🇪Ireland lostcarpark
Updated .gitlab-ci.yml to delete recipes before running eslint. Checks are now passing.

Ready for review.
Pipeline finished with Skipped
10 days ago
#365882
Comment 10 days ago →
System Message

chrisfromredfin → committed 714f3b46 on 2.0.x authored by lostcarpark →
Issue #3493332: ESLint should not lint dependencies
Comment 10 days ago →
🇺🇸United States chrisfromredfin Portland, Maine
Thanks!
Pipeline finished with Success
10 days ago
Total: 484s
#365873

contrib.social Blog FAQ Discussions

Production build 0.71.5 2024