Do not store error results in KeyValue storage

We should probably ship 🐛 EnabledSourceHandler should segment its storage more strongly Active before tackling this.

Suggested code, if the above is merged:

    if (empty($results->error)) {
      // Store the query results as a set of arguments to ProjectsResultsPage only if there are no errors.
      $storage->set($cache_key, [
        $results->totalResults,
        array_column($results->list, 'id'),
        $results->pluginLabel,
        $source_id,
        $results->error,
      ]);
    }

The code looks good and the test shows that when there is an error nothing gets stored. RTBC.

feed-baby-airplane-into-hangar.gif

Automatically closed - issue fixed for 2 weeks with no activity.