EnabledSourceHandler should segment its storage more strongly

Created on 9 January 2025, 3 months ago

EnabledSourceHandler is still messy, because it suffers from the old design that presumed that Project Browser had internal tabbing and could store all data, for all tabs, in one place.

Let's improve that:

  • It should no longer be possible to send a query to the backend proxy without a source ID.
  • Queries and results for each source should be cached by EnabledSourceHandler in a key-value storage specific to that source.
  • It should be possible to clear storage for a single source.
πŸ› Bug report
Status

Active

Version

2.0

Component

Code

Created by

πŸ‡ΊπŸ‡ΈUnited States phenaproxima Massachusetts

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

  • Issue created by @phenaproxima
  • Merge request !668Segment the stored project data β†’ (Merged) created by phenaproxima
  • Pipeline finished with Failed
    3 months ago
    Total: 460s
    #391085
  • Pipeline finished with Failed
    3 months ago
    Total: 725s
    #391086
  • Pipeline finished with Failed
    3 months ago
    Total: 302s
    #391198
  • Pipeline finished with Failed
    3 months ago
    Total: 726s
    #391207
  • Pipeline finished with Failed
    2 months ago
    Total: 431s
    #401993
  • Pipeline finished with Failed
    2 months ago
    Total: 294s
    #402003
  • Pipeline finished with Failed
    2 months ago
    Total: 340s
    #402006
  • Pipeline finished with Canceled
    2 months ago
    Total: 152s
    #402010
  • Pipeline finished with Failed
    2 months ago
    Total: 332s
    #402012
  • Pipeline finished with Canceled
    2 months ago
    Total: 115s
    #402016
  • Pipeline finished with Failed
    2 months ago
    Total: 337s
    #402017
  • Pipeline finished with Failed
    2 months ago
    Total: 220s
    #402019
  • Pipeline finished with Canceled
    2 months ago
    Total: 90s
    #402020
  • Pipeline finished with Failed
    2 months ago
    Total: 250s
    #402022
  • πŸ‡ΊπŸ‡ΈUnited States phenaproxima Massachusetts
  • Pipeline finished with Failed
    2 months ago
    Total: 363s
    #402031
  • Pipeline finished with Success
    2 months ago
    Total: 456s
    #402074
  • πŸ‡ͺπŸ‡ΈSpain fjgarlin

    The code looks good and it reflects what we need. However, I don't see the tabs anymore (not sure this is introduced by these changes). I enabled core and contrib modules.

    https://8080-project-drupalpod....gitpod.io/admin/modules/browse/drupalorg_jsonapi shows contrib modules
    https://8080-project-drupalpod....gitpod.io/admin/modules/browse/drupal_core shows core modules

    But there are no tabs shown in the front end, at all. No JS errors, no watchdog errors.

    Using the developer tools we can see that the project-browser/data/categories returns data for the two enabled plugins.
    The project-browser/data/project only returns data for the plugin that is present in the URL.

    I'm going to test with 2.0.x and see if this happens.

  • Pipeline finished with Success
    2 months ago
    Total: 879s
    #402913
  • Pipeline finished with Skipped
    2 months ago
    #402944
  • First commit to issue fork.
  • πŸ‡ΊπŸ‡ΈUnited States chrisfromredfin Portland, Maine

    yeah boi, onward and upward

  • Automatically closed - issue fixed for 2 weeks with no activity.

  • Pipeline finished with Failed
    about 1 month ago
    Total: 925s
    #439533
  • Pipeline finished with Success
    about 1 month ago
    Total: 1753s
    #439553
  • Pipeline finished with Success
    about 1 month ago
    Total: 2234s
    #439564
  • Pipeline finished with Failed
    about 1 month ago
    Total: 1482s
    #439628
  • Pipeline finished with Running
    about 1 month ago
    #439663
Production build 0.71.5 2024