- Issue created by @chrisfromredfin
- First commit to issue fork.
- Merge request !679#3499411:After composer error on install, card incorrectly reflects "Installed" status → (Merged) created by utkarsh_33
- 🇺🇸United States phenaproxima Massachusetts
This makes sense. I don't love how currentQueueList works, but that's not something that came from this issue, so is out of scope to change here. I think this could use a test, though, if it's not too tricky.
- 🇺🇸United States phenaproxima Massachusetts
This will need a rebase after 📌 Remove $activeTab from the Svelte code Active , which totally removed the weirdo
$activeTab
variable. - 🇮🇳India utkarsh_33
Added tests.We can also merge the tests into
testCanBreakLock()
test as we just need a small assertion.But to keep things simple i just copied and added the extra assertions in a new test.Marking it NR for opinions. - 🇺🇸United States phenaproxima Massachusetts
Only one suggestion but otherwise I am fine with repeating the test code. Cleaning up the tests is not in scope here. Calling this RTBC but would appreciate someone with commit access applying my suggestion before merging. :)
- 🇺🇸United States chrisfromredfin Portland, Maine
I rebased this to test and push, but now the NEW test is failing. NULL is not empty?
-
chrisfromredfin →
committed cf986400 on 2.0.x authored by
utkarsh_33 →
Issue #3499411: After composer error on install, card incorrectly...
-
chrisfromredfin →
committed cf986400 on 2.0.x authored by
utkarsh_33 →
- 🇺🇸United States chrisfromredfin Portland, Maine
Confirmed working, even with manual testing (found a module that errored). Nice improvement!
Automatically closed - issue fixed for 2 weeks with no activity.