GitLab CI - test for previous and next minor versions, and maximum PHP version

 ------ ----------------------------------------------------------------------- 
  Line   src/Controller/InstallerController.php                                 
 ------ ----------------------------------------------------------------------- 
  311    Call to deprecated method renderPlain() of class                       
         Drupal\Core\Render\Renderer:                                           
         in drupal:10.3.0 and is removed from drupal:12.0.0. Use                
           \Drupal\Core\Render\RendererInterface::renderInIsolation() instead.  
 ------ ----------------------------------------------------------------------- 

The fix for this is suggested in comments https://www.drupal.org/node/3407994 → , please confirm if you want to proceed with this.

I've listed the failures in the Proposed Resolution section. The main thing i don't know is how to variegate a test for two different outcomes - eg where the status message has changed after you install a module.

I temporarily disabled OPT_IN_TEST_PREVIOUS_MINOR coverage (10.1 becomes unsupported July) just to have better clarity on what needs to be done.

I have fixed everything except InstallerControllerTest::testInstallUnlockMessage. I don't know what is happening there on 10.3. It should be running into a lock in this test but nothing is returned from the tempstore.

Note that I merged the fixes on 📌 project_browser_test.time service tests fail on 10.3 Needs review into this (to make it easier to track progress), so please merge that first to give credit to @kimpepper and @mstrelan.

Adding relationship to 📌 Run tests on 11.x Active as there is overlapping work.

Passing, I picked a few things that seemed like improvements/fixes over head. Please also credit kimpepper and mstrelan for the deprecation helper help.

I love that DeprecationHelper thing. Wish I'd known about it before! But hey, you gotta learn sometime.

The only thing is that we shouldn't be using Workspaces to test experimental stuff.

I'm not sure about Workspaces, the test is pre-existing and seems to just be a canary test. But now that Workspaces is marked stable in 10.3 do we even need this test?

Yes. We do want to test that Project Browser handles experimental modules in a particular way. The use of Workspaces was probably just a convenience thing at the time.

Ok i see where I've misunderstood the purpose of the test. Lemme fix.

This rocks!

when I bump you bump we bump (version numbers)

Automatically closed - issue fixed for 2 weeks with no activity.