Run tests on 11.x and declare compatibility with it

Created on 10 May 2024, 7 months ago
Updated 16 June 2024, 5 months ago

Problem/Motivation

So, uh...we want to be compatible with Drupal 11, right? Of course we do. Let's therefore make sure our tests are running against 11.x, as well as the current minor version of core.

πŸ“Œ Task
Status

Fixed

Version

1.0

Component

Code

Created by

πŸ‡ΊπŸ‡ΈUnited States bnjmnm Ann Arbor, MI

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

  • Issue created by @bnjmnm
  • Merge request !47811.x support β†’ (Merged) created by bnjmnm
  • First commit to issue fork.
  • Pipeline finished with Failed
    7 months ago
    #169821
  • Pipeline finished with Failed
    7 months ago
    Total: 151s
    #169828
  • Pipeline finished with Failed
    7 months ago
    Total: 432s
    #169837
  • Pipeline finished with Failed
    6 months ago
    Total: 380s
    #178112
  • Pipeline finished with Failed
    6 months ago
    #178118
  • Pipeline finished with Failed
    6 months ago
    Total: 229s
    #178121
  • Pipeline finished with Failed
    6 months ago
    Total: 469s
    #178126
  • Pipeline finished with Failed
    6 months ago
    Total: 454s
    #185218
  • Pipeline finished with Failed
    6 months ago
    Total: 375s
    #185219
  • Pipeline finished with Failed
    6 months ago
    Total: 428s
    #185231
  • Pipeline finished with Canceled
    6 months ago
    #185237
  • Pipeline finished with Failed
    6 months ago
    Total: 240s
    #185239
  • Pipeline finished with Failed
    6 months ago
    Total: 496s
    #185244
  • Pipeline finished with Canceled
    6 months ago
    Total: 50s
    #185252
  • Pipeline finished with Canceled
    6 months ago
    Total: 215s
    #185254
  • Pipeline finished with Failed
    6 months ago
    Total: 465s
    #185259
  • Pipeline finished with Failed
    6 months ago
    #185270
  • Pipeline finished with Failed
    6 months ago
    Total: 571s
    #185288
  • Pipeline finished with Canceled
    6 months ago
    Total: 328s
    #186451
  • Pipeline finished with Failed
    6 months ago
    Total: 519s
    #186460
  • Pipeline finished with Failed
    6 months ago
    #186468
  • Status changed to Needs review 6 months ago
  • πŸ‡ΊπŸ‡ΈUnited States phenaproxima Massachusetts
  • Pipeline finished with Failed
    6 months ago
    #186480
  • Pipeline finished with Failed
    6 months ago
    Total: 457s
    #186527
  • Pipeline finished with Canceled
    6 months ago
    Total: 103s
    #186541
  • Pipeline finished with Success
    6 months ago
    Total: 607s
    #186544
  • πŸ‡ΊπŸ‡ΈUnited States phenaproxima Massachusetts
  • πŸ‡¦πŸ‡ΊAustralia sime Melbourne

    Just a heads up (i'm not sure what to do if anythin), there is overlapping work with πŸ“Œ GitLab CI - test for previous and next minor versions, and maximum PHP version Needs review which notably has a different solution to make the TestTime service work.

  • πŸ‡¦πŸ‡ΊAustralia sime Melbourne

    If it helps any, the alternative TestTime changes are isolated in this MR https://git.drupalcode.org/project/project_browser/-/merge_requests/487/...

  • πŸ‡ΊπŸ‡ΈUnited States phenaproxima Massachusetts

    Thanks @sime. I think it's fine to use \Drupal::state() in TestTime, instead of fancy-pants dependency injection, since it's just a test class. But, I'll respect whichever MR lands first.

  • πŸ‡¦πŸ‡ΊAustralia sime Melbourne

    I only barely understand it but it does seem cool. Do we close another of these other issues and focus on this one?

  • πŸ‡ΊπŸ‡ΈUnited States phenaproxima Massachusetts

    If there are other issues about 11.x compatibility, I'm guessing we should generally ignore them, at least for now, since this is probably the furthest along...?

  • Pipeline finished with Failed
    6 months ago
    Total: 256s
    #186858
  • Pipeline finished with Failed
    6 months ago
    Total: 225s
    #186864
  • Pipeline finished with Failed
    6 months ago
    Total: 557s
    #186868
  • πŸ‡ΊπŸ‡ΈUnited States phenaproxima Massachusetts

    You probably want to know what I changed in the test fixtures, since the diffs are too big for GitLab to show. What I changed was simple: I did an automatic search-and-replace. This:

    core_semver_maximum: 10000000

    became this:

    core_semver_maximum: 99000000

    That's it.

  • Pipeline finished with Skipped
    6 months ago
    #187568
    • bnjmnm β†’ committed 3a19915f on 1.0.x
      Issue #3446528: Run tests on 11.x and declare compatibility with it
      
  • Status changed to Fixed 6 months ago
  • πŸ‡ΊπŸ‡ΈUnited States bnjmnm Ann Arbor, MI

    This all looks fine and I think it's good to get 11x testing in ASAP as that may wind up being the version where this debuts and it would be unfortunate to have to do a bunch of catchup because this was written for a version that is out of date by the time D.O. is ready for Project Browser.

  • πŸ‡¦πŸ‡ΊAustralia sime Melbourne

    Next/previous Minor support ready for review https://www.drupal.org/project/project_browser/issues/3423697 πŸ“Œ GitLab CI - test for previous and next minor versions, and maximum PHP version Needs review

  • Automatically closed - issue fixed for 2 weeks with no activity.

Production build 0.71.5 2024