- Issue created by @bnjmnm
- First commit to issue fork.
- Status changed to Needs review
6 months ago 7:31pm 30 May 2024 - π¦πΊAustralia sime Melbourne
Just a heads up (i'm not sure what to do if anythin), there is overlapping work with π GitLab CI - test for previous and next minor versions, and maximum PHP version Needs review which notably has a different solution to make the TestTime service work.
- π¦πΊAustralia sime Melbourne
If it helps any, the alternative TestTime changes are isolated in this MR https://git.drupalcode.org/project/project_browser/-/merge_requests/487/...
- πΊπΈUnited States phenaproxima Massachusetts
Thanks @sime. I think it's fine to use \Drupal::state() in TestTime, instead of fancy-pants dependency injection, since it's just a test class. But, I'll respect whichever MR lands first.
- π¦πΊAustralia sime Melbourne
I only barely understand it but it does seem cool. Do we close another of these other issues and focus on this one?
- πΊπΈUnited States phenaproxima Massachusetts
If there are other issues about 11.x compatibility, I'm guessing we should generally ignore them, at least for now, since this is probably the furthest along...?
- πΊπΈUnited States phenaproxima Massachusetts
You probably want to know what I changed in the test fixtures, since the diffs are too big for GitLab to show. What I changed was simple: I did an automatic search-and-replace. This:
core_semver_maximum: 10000000
became this:
core_semver_maximum: 99000000
That's it.
-
bnjmnm β
committed 3a19915f on 1.0.x
Issue #3446528: Run tests on 11.x and declare compatibility with it
-
bnjmnm β
committed 3a19915f on 1.0.x
- Status changed to Fixed
6 months ago 7:26pm 31 May 2024 - πΊπΈUnited States bnjmnm Ann Arbor, MI
This all looks fine and I think it's good to get 11x testing in ASAP as that may wind up being the version where this debuts and it would be unfortunate to have to do a bunch of catchup because this was written for a version that is out of date by the time D.O. is ready for Project Browser.
- π¦πΊAustralia sime Melbourne
Next/previous Minor support ready for review https://www.drupal.org/project/project_browser/issues/3423697 π GitLab CI - test for previous and next minor versions, and maximum PHP version Needs review
Automatically closed - issue fixed for 2 weeks with no activity.