Contrib.social

"Clear filters" should also reset the keyword search

Open on Drupal.org →
Created on 11 February 2025, 2 months ago

Problem/Motivation

Now that we've moved the search into the gray box and tightened everything up (see parent issue), it seems like the "Clear filters" button should also reset the keyword search.

Steps to reproduce

Open PB. Search for something using a keyword (ex.g. "token"). Click "Clear filters" and note that it does not reset your "token" keyword search; results still reflect a limited set.

Proposed resolution

in Search.svelte, function clearFilters() should also set $filters.search = ''; (or, is the issue that filterDefinitions doesn't include search in it, and should? There are related issues about this... which may be the actual fix here).

We should also include a test that checks that the "Clear filters" also resets the search keyword. It seems most likely that this could go at the bottom of testClearKeywordSearch(). I had the following code; however, it did not work!

    // Ensure that we also clear the keyword using the clear filters button.
    // Search for something to change it.
    $this->inputSearchField('abcdefghijklmnop', TRUE);
    $assert_session->waitForElementVisible('css', ".search__search-submit")?->click();
    $this->assertTrue($results->waitFor(10, fn (NodeElement $element) => $element->getText() !== $original_text));
    $this->pressWithWait('Clear filters');
    $this->assertTrue($results->waitFor(10, fn (NodeElement $element) => $element->getText() === $original_text));
✨ Feature request
Status

Active

Version

2.0

Component

User experience

Created by

🇺🇸United States chrisfromredfin Portland, Maine

Live updates comments and jobs are added and updated live.
  • Needs tests

    The change is currently missing an automated test that fails when run with the original code, and succeeds when the bug has been fixed.

Sign in to follow issues

Merge Requests

Comments & Activities

contrib.social Blog FAQ Discussions
Production build 0.71.5 2024