Regression: dropdowns no longer look the same

Created on 20 October 2023, about 1 year ago
Updated 19 June 2024, 5 months ago

Problem/Motivation

The select / dropdowns at the right of filters now have white backgrounds in Claro since πŸ“Œ Move styles out of svelte bundle to traditional Drupal library Fixed

Steps to reproduce

Use fork for 3394904 (or HEAD since 3394904 was merged).

Proposed resolution

  1. determine if we need to do anything
  2. do it or close
πŸ› Bug report
Status

Fixed

Version

1.0

Component

User experience

Created by

πŸ‡ΊπŸ‡ΈUnited States chrisfromredfin Portland, Maine

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

  • Issue created by @chrisfromredfin
  • πŸ‡ΊπŸ‡ΈUnited States chrisfromredfin Portland, Maine
  • πŸ‡ΊπŸ‡ΈUnited States chrisfromredfin Portland, Maine
  • First commit to issue fork.
  • Merge request !411Fix regression in filter and sort select β†’ (Merged) created by gbois
  • Open in Jenkins β†’ Open on Drupal.org β†’
    Core: 10.1.x + Environment: PHP 8.1 & MySQL 5.7
    last update about 1 year ago
    77 pass
  • First commit to issue fork.
  • Status changed to Needs review 6 months ago
  • πŸ‡¦πŸ‡ΊAustralia sime Melbourne

    Rebased.

    Before

    After

  • Pipeline finished with Failed
    6 months ago
    Total: 505s
    #179930
  • πŸ‡©πŸ‡ͺGermany rkoller NΓΌrnberg, Germany

    hm a few thoughts. "technically" sort by is not a button but a select field so the greyish regular button background feels off and semantically wrong. while on the other hand the grey for the filter is semantically correct since it is a toggle button. but that filter button has a border (#919297) buttons usually dont have according to the drupal design system? also on hover that border gets solid dark/black instead of changing the background to a darker grey, also not in line with the drupal design system. i am not sure if styling the filter toggle button and the select field the same way is the right call here. those are different kinds of interface elements. and from an accessibility point view the background of the select field (#D3D4D9) against the filter section background (#F3F4F9) results in 1.3:1 , WCAG 2.2. SC 1.4.11 would require at least a color contrast of 3:1. the filter toggle button would have the same issue but with the border in place it is "slightly" better but still not meeting SC1.4.11. border (#919297) against the filter section background (#F3F4F9) has 2.8:1 and border (#919297) against filter section background (#F3F4F9) gets 2.1:1. and then there is also πŸ“Œ Improve the categories filter type in context to the rest of the filter component ui Fixed which would change that entire filter section. and strictly speaking the sort select field wouldnt be part of the filter section anymore since it gets untwined.

  • Status changed to RTBC 6 months ago
  • πŸ‡ΊπŸ‡ΈUnited States bernardm28 Tennessee

    After looking into this issue, It seems to have accomplished the requirements. I tested it with drupalPod.
    Hence, I'm setting it to RTBC.
    I agree with @rkoller on most suggested changes but we are likely to address those in a follow-up ticket. I can open that.
    Additionally, we will likely have to roll out the Drupal design systems everywhere once we are merged into core. So it might be postponed a little but it's coming. #331817 is not ready yet, but it is a good idea to reference it.

  • Pipeline finished with Skipped
    6 months ago
    #191234
  • Status changed to Fixed 6 months ago
  • πŸ‡ΊπŸ‡ΈUnited States chrisfromredfin Portland, Maine

    with gratitude!

  • Automatically closed - issue fixed for 2 weeks with no activity.

Production build 0.71.5 2024