- Issue created by @alexpott
- Assigned to alexpott
- πΊπΈUnited States thejimbirch Cape Cod, Massachusetts
Assigning to @alexpott as he stated he had a WIP in Slack.
- π¬π§United Kingdom alexpott πͺπΊπ
alexpott β changed the visibility of the branch 3439702-allow-cli-install to hidden.
- Status changed to Needs review
7 months ago 7:49am 25 April 2024 - π¬π§United Kingdom alexpott πͺπΊπ
Okay here's a clip of this working by doing
php core/scripts/drupal quick-start --recipe core/recipes/standard
- Status changed to Needs work
7 months ago 4:39pm 25 April 2024 - πΊπΈUnited States phenaproxima Massachusetts
This mostly makes sense to me. I think it feels a little messy, but since this is all internal, we're free to refactor it later.
- Status changed to Needs review
7 months ago 10:30pm 25 April 2024 - π¬π§United Kingdom alexpott πͺπΊπ
Addressed @phenaproxima's review and fixed a bug in our Standard recipe.
- πΊπΈUnited States thejimbirch Cape Cod, Massachusetts
I was successfully able to quick start using a recipe.
I reset, and I was also able to quick start using a smaller core recipe like the
article_content_type
I was also able to apply recipes after the install. The first, failed, applying standard after article, but that is nothing to do with the installer. The second applied just fine.
Since all threads from the code review were resolved, and validation steps pass, I am moving this to RTBC. If you feel it needs more work, please move it back. Thanks!
- Status changed to RTBC
7 months ago 12:47am 26 April 2024 - π¬π§United Kingdom alexpott πͺπΊπ
FWIW if you want to test applying a recipe after installing core/recipe/standard then any of:
core/recipes/editorial_workflow core/recipes/audio_media_type core/recipes/document_media_type core/recipes/image_media_type core/recipes/local_video_media_type core/recipes/remote_video_media_type
will work well.
- πΊπΈUnited States phenaproxima Massachusetts
I reviewed the code here and didn't find anything I'd consider commit-blocking. There are some minor phrasing things, comment nits, and stylistic suggestions, but overall I'm seconding the RTBC here.
-
alexpott β
committed 067d4a41 on 10.3.x
Issue #3439702 by alexpott, thejimbirch, phenaproxima: Allow CLI install...
-
alexpott β
committed 067d4a41 on 10.3.x
- Status changed to Fixed
7 months ago 4:01pm 26 April 2024 -
alexpott β
committed 4b90b742 on 11.x
Issue #3439702 by alexpott, thejimbirch, phenaproxima: Allow CLI install...
-
alexpott β
committed 4b90b742 on 11.x
- π¬π§United Kingdom alexpott πͺπΊπ
Cherry-picked to β¨ Add recipes api as experimental API to core Needs review
- ab4d9ab4 committed on patch
Update recipe 10.3.x patch 067d4a41 Issue #3439702 by alexpott,...
- ab4d9ab4 committed on patch
- 24476ede committed on patch
Update recipe 11.x patch 4b90b742 Issue #3439702 by alexpott,...
- 24476ede committed on patch
- Issue was unassigned.
Automatically closed - issue fixed for 2 weeks with no activity.