Error messages should utilize Drupal's messages

adding solution

🙌 🙌 🙌

Works fine for me. Needed another rebuild of the JS though.

Also, since the error message contains HTML markup, the placeholder used in Drupal.t should be prefixed with ! instead of @ so the markup does not get escaped.

Since I only changed the variable escaping in my previous commit and everything else looked fine, I'll mark this as RTBC.

Looks like tests not passing CS

Rebased, which made the tests work except for some sporadic timing-based failures on occasion. Increased timeout of waitForElementVisible() calls that I've seen failing.

Updated the MR against 1.0.x again to make it fit to merge. Test failures seem unrelated, fine on second run.

Marking as RTBC again.

chrisfromredfin → closed merge request !417

MR !319 is the right one to use, but needs a rebase.

MR is up-to-date again

Given this error:

There was 1 error:
    
    1)
    Drupal\Tests\project_browser\FunctionalJavascript\ProjectBrowserPluginTest::testPaging
    Behat\Mink\Exception\ExpectationException: 2 elements matching css
    ".pager__item--next" found on the page, but should be 1.

I think the rebase might be a little bad. We did merge a fix last week to remove the top pager, but it seems like the test is now checking for one pager, but there are still two pagers being displayed.

(Wow, thanks automated tests!)

Oops, my bad, should have waited for the pipeline!

Removed the offending pager, pipeline's green now!

Updated against 1.0.x, MR is mergeable again.

Seems to be working as expected.

ESLint and PHPStan are failing. The PHPStan failures should be solved with a rebase, based on a commit I made yesterday (h/t James Shields).

The ESLint errors I'm less sure about, but they certainly need to be fixed regardless.

The test failure with the phpunit functional test is weird on this one.
Not sure that error is related to the changes here.

I think as the result of a bad rebase, this re-introduces a pager at the top of the Project Browser; there should only be one pager at the bottom. The test caught exactly this situation.

Needs to be rebased / re-applied clean to latest 1.0.x.

bernardm28 → changed the visibility of the branch 1.0.x to hidden.

beta blocker DOWN! Thanks so much everyone! big news. :)

Automatically closed - issue fixed for 2 weeks with no activity.